Quick attempt at fixing EOF error issue encountered on linux/ARM #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to run gcfuse on linux/ARM, ran into the issue described here: GoogleCloudPlatform/gcsfuse#197 Change the API slightly (expose even less), and switch to using a local unix socket (assuming windows is not a primary target for gcsfuse) for communicating back status to the parent process.
|
Thanks for this. Can you describe here and in your commit message what the problem was? |
|
Well, unfortunately I didn't really dig too deep into why things didn't work, I noticed that things ran fine with --foreground and proceeded to just make this last bit work for me by simply using a unix socket as it feels a bit more flexible for that sort of non performance-critical IPC anyway. Though it's interesting that the other report also happened to be on ARM. |
jacobsa
requested changes
Apr 5, 2017
| // process. Though the tool starts the daemon process with stdin, stdout, and | ||
| // stderr closed (using Run), the daemon should be able to communicate status | ||
| // to the user while it starts up (using StatusWriter), causing the tool to | ||
| // This package provides the convenience for writing a tool that spins itself |
| pipeW *os.File) (err error) { | ||
| func startProcess(args []string, status io.Writer) error { | ||
|
|
||
| // TODO: drop osext dependency once minmum required go verison is 1.8 |
There was a problem hiding this comment.
Please just do this now. Those binaries that need to build with older versions of Go can vendor an old version.
| @@ -129,47 +124,42 @@ func (w *logMsgWriter) Write(p []byte) (n int, err error) { | |||
| return | |||
| } | |||
|
|
|||
| // For use by the daemon: the writer that should be used for logging status | |||
|
This is still a blocking issue on ARM builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run gcfuse on linux/ARM, ran into the issue described
here:
GoogleCloudPlatform/gcsfuse#197
Change the API slightly (expose even less), and switch to using a local
unix socket (assuming windows is not a primary target for gcsfuse) for
communicating back status to the parent process.