Fix RenameOp compatibility with macfuse 4.x #107
Conversation
| // closed-source macfuse 4.x has broken compatibility with osxfuse 3.x: | ||
| // it passes an additional 64-bit field (flags) after RenameIn regardless | ||
| // that we don't enable the support for RENAME_SWAP/RENAME_EXCL | ||
| // the simplest fix is just to check for the presence of all-zero flags |
There was a problem hiding this comment.
Would it be much harder to enable support for RENAME_SWAP/RENAME_EXCL?
The current approach seems pretty hackish…
There was a problem hiding this comment.
Hi, sorry for long absence. There are some quirks - as I understand macfuse kernel module doesn't indicate the format in any way if you don't request these features in the init function yourself (the author did a bad thing), and I'm not sure what happens if you do request it with older osxfuse versions - maybe they'll decide that you want a missing feature and fail.
So it would require some testing with different versions of macos and I'm not a huge closed-source systems fan, even I had a macbook the first thing that I'd do would be to remove macos and install Linux :)
These features are mac-specific, Linux and POSIX in general doesn't have them. So... I don't know. I don't want to spend a lot of time testing different macos versions currently, and I think this change is anyway good for your library because it at least fixes normal rename support. :-)
There was a problem hiding this comment.
Hi, sorry for long absence. There are some quirks - as I understand macfuse kernel module doesn't indicate the format in any way if you don't request these features in the init function yourself (the author did a bad thing), and I'm not sure what happens if you do request it with older osxfuse versions - maybe they'll decide that you want a missing feature and fail.
Ugh, that sounds annoying. But maybe it could be fixed on the osxfuse? Have you tried reporting it to the developers?
So... I don't know. I don't want to spend a lot of time testing different macos versions currently, and I think this change is anyway good for your library because it at least fixes normal rename support. :-)
I don’t have time to maintain this library for macOS, so unfortunately I can’t just accept code contributions where the author (you, in this case) doesn’t have time to maintain or change/verify/debug the code.
There was a problem hiding this comment.
:-) something like that. This change definitely works as it's simple and it's included in https://github.com/yandex-cloud/geesefs builds and tested by colleagues at Yandex many of whom are mac users )). In fact the bug was initially found by the author of our another internally used fuse-based FS (with a C++ binding). I tried reporting the problem but he came over to that bug and said that he doesn't want them to break compatibility the second time ))). So, yeah. Pretty annoying.))
There was a problem hiding this comment.
Also I don't like the idea of rename with additional flags/modes at all. POSIX doesn't have it...
There was a problem hiding this comment.
Do you insist on adding the support for rename_swap/rename_excl? If you say so I can try to do that at some point. Until then renames will just remain broken under macfuse :-)
There was a problem hiding this comment.
Thanks for the context. Can you expand the comment stating that you tried reporting this to osxfuse upstream but they are unwilling to revert the change?
Also, can you rebase your changes to the latest master branch contents and ensure you’re formatting the file with gofmt please?
There was a problem hiding this comment.
Done, updated the branch
vitalif
force-pushed
the
macfuse-rename
branch
from
0ef0830
to
3703c51
Compare
Closed-source macfuse 4.x has broken compatibility with osxfuse 3.x: it passes an additional 64-bit field (flags) after RenameIn regardless that we don't enable the support for RENAME_SWAP/RENAME_EXCL. The simplest fix is just to check for the presence of all-zero flags and strip them when they're present.
vitalif
force-pushed
the
macfuse-rename
branch
from
3703c51
to
1c976be
Compare
|
Thanks! |
|
Thank you for merging, I'll get to the other PR soon too :-) |
Closed-source macfuse 4.x has broken compatibility with osxfuse 3.x: it passes an additional 64-bit field (flags) after RenameIn regardless that we don't enable the support for RENAME_SWAP/RENAME_EXCL.
The simplest fix is just to check for the presence of all-zero flags and strip them when they're present.