Add support for the FUSE_BATCH_FORGET operation #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stapelberg
requested changes
May 27, 2022
There are certain Kernel versions which do not send individual Forget operations after they receive "not implemented" for Batch Forget. One example is "5.4.0-110-generic" on Ubuntu 20.04. I am sure there are plenty of others. This leads to inode "leaks". Where reference counts are never decreased and the inodes were left hanging around long after they are not needed any more. The best way to fix that was adding support for batch operations to the lib. This way all users will be able to benefit from the batching optimization.
ironsmile
force-pushed
the
implement-the-batch-forget-operation
branch
from
3dbbba4
to
e3e4e37
Compare
|
You are welcome! I've rebased it to the latest master from 9 minutes ago too. Hope it builds now 😄 |
|
Thanks! |
|
Thanks, I did just the same thing yesterday and today I discovered that it's already done here :)) One thing I want to add is #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain Kernel versions which do not send individual
Forget operations after they receive "not implemented" for Batch Forget.
One example is "5.4.0-110-generic" on Ubuntu 20.04. I am sure there are
plenty of others.
This leads to inode "leaks". Where reference counts are never decreased
and the inodes were left hanging around long after they are not needed
any more.
The best way to fix that was adding support for batch operations to the
lib. This way all users will be able to benefit from the batching
optimization.