Handling error during initOp response to kernel #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do not handle errors while responding to the kernel. Ideally, we should handle this for all operations; however, that requires more changes. Currently, we are narrowing the scope to errors that occur while communicating the InitOp response to the kernel. This will fail the mounting process, which is not happening right now.
Related issues: GoogleCloudPlatform/gcsfuse#583
I have manually tested by adding a custom error message while writing a message. However, I am not able to reproduce the above mentioned issue.
Impact:
After this change, if the user-daemon fails to respond the kernel for initOp with an error, the user will not be able to mount successfully.