Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for fallocate #66

Merged
merged 2 commits into from
Oct 26, 2019
Merged

add support for fallocate #66

merged 2 commits into from
Oct 26, 2019

Conversation

kahing
Copy link
Contributor

@kahing kahing commented Jun 24, 2019

No description provided.

@kahing
Copy link
Contributor Author

kahing commented Jun 24, 2019

go test ./samples/... passed on ubuntu 16.04. Not clear why travis is failing though, seems like it failed with similar errors in previous commits

@stapelberg
Copy link
Collaborator

Would you mind rebasing this on the current master branch please? We fixed the travis config in the meantime.

@kahing kahing force-pushed the fallocate branch 2 times, most recently from 5b5ab3a to 52f9d0c Compare October 24, 2019 13:56
@kahing
Copy link
Contributor Author

kahing commented Oct 24, 2019

@stapelberg @jacobsa I rebased and it timed out on linux while passing on OS X and it's not clear why. It passes locally on ubuntu 16.08.

@stapelberg
Copy link
Collaborator

@stapelberg @jacobsa I rebased and it timed out on linux while passing on OS X and it's not clear why. It passes locally on ubuntu 16.08.

I restarted the travis run, and it worked.

@stapelberg stapelberg merged commit 4ee1cf7 into jacobsa:master Oct 26, 2019
@kahing
Copy link
Contributor Author

kahing commented Oct 26, 2019

thanks @stapelberg !

@kahing kahing deleted the fallocate branch October 26, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants