Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Can I create a pull request for the docking fix? #97

Closed
theryan722 opened this issue Jul 30, 2015 · 4 comments
Closed

Can I create a pull request for the docking fix? #97

theryan722 opened this issue Jul 30, 2015 · 4 comments

Comments

@theryan722
Copy link
Contributor

Or is that something you are leaving up to the user. Thanks.
@jacobslusser
Copy link
Owner

Remind me again, what is the "docking fix"?

@theryan722
Copy link
Contributor Author

From Issue #85 the fix that was implemented in v2.x

@jacobslusser
Copy link
Owner

Oh, THAT "docking fix". :)

Thanks for the offer, but I'm probably going to incorporate the v2 fix as a configuration option developers can opt into and also explore some of the other options.

Just busy with my day job. :)

@theryan722
Copy link
Contributor Author

No problem, guess I won't be vanilla until the option comes out haha

jacobslusser added a commit that referenced this issue Oct 14, 2015
@jacobslusser
Issues #85, #93, #97, #123. Call SetDestroyHandleBehavior(true) to te…
d632e6e 
…st fix.

Added a new opt-in method SetDestroyHandleBehavior(true) to work around
issues with the control being sent WM_DESTROY messages when we don't
want them.
jacobslusser added a commit that referenced this issue Jul 24, 2016
@jacobslusser
Made the WM_DESTROY fix official
9e543b2 
The fix for #85, #93, #97 and #123 has been out and vetted by users for
quite a while now and so I'm making it the default behavior. Instead of
calling SetDestroyHandleBehavior(true) to enable it, it is now enabled
by default and can be disabled by calling
SetDestroyHandleBehavior(false).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobslusser @theryan722