Add test to check order consistency #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This is very interesting. Do you think all these ones that fail really have errors of some sort? I'll make a ticket for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it might be useful to make some sanity checks on the methods and their implementations. To this purpose, I've implemented a simple test to check if a method is consistent with its order. Please refer to the explanation in the heading of
./test/rk_test_order.F90.Run it with:
fpm test rk_test_orderMost methods pass the test, but some do fail, suggesting that something is wrong with said methods or their implementation.
One of the methods that fails is
rkls44, implemented by me. I will try to figure out the problem and fix it in a subsequent PR.