This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
Explicitly require hamcrest core so we don't rely on other bundles re-exporting API #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundles re-exporting API.
|
Sounds reasonable, many thanks! |
marchof
added a commit
that referenced
this pull request
Jan 23, 2015
Explicitly require hamcrest core so we don't rely on other bundles re-exporting API
|
@mbooth101 Do you urgently need a release for this? |
|
We are carrying this patch in Fedora, so we will drop the patch when you make your next release -- no urgency needed :-) Thanks for merging, btw! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
As a linux distro integrator it is a hard rule that we must build everything from source, which includes the restrictions on re-using pre-built binary artefacts from Orbit. Because we can't re-use things from Orbit, it means that osgi metadata sometimes differs between the upstream project's builds and Orbit builds of a given third-party dependency. We try to stay as close as possible to the upstream project's build to reduce our patch maintenance burden.
The problem:
The com.mountainminds.eclemma.core.test relies on hamcrest core, it does not import "org.hamcrest.core" in the manifest. This means that when re-building against versions of junit that do not reexport the hamcrest core API, the build will fail. Adding an extra requirement on the "org.hamcrest.core" bundle will prevent such a failure.
This pull request contains a small (two-line) patch that makes the dependency on hamcrest more explicit.