Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android "viewModelScope.launch" block partially covered for Kotlin 1.4.20 #1126

Closed
ugurcany opened this issue Nov 25, 2020 · 0 comments · Fixed by #1149
Closed

Android "viewModelScope.launch" block partially covered for Kotlin 1.4.20 #1126

ugurcany opened this issue Nov 25, 2020 · 0 comments · Fixed by #1149
Assignees
@Godin
Labels
component: core.filters type: bug 🐛 Something isn't working
Projects
Current work items Filtering
Milestone
0.8.7

Comments

@ugurcany
Copy link

ugurcany commented Nov 25, 2020 •
edited

Steps to reproduce

  • JaCoCo version: 0.8.6.202009150832
  • Operating system: MacOS
  • Steps: I'm using jacoco tool for code coverage reporting in my Android project. After I incremented the Kotlin version from 1.4.10 to 1.4.20, jacoco reports started showing coverages for viewModelScope.launch { ... } blocks as "partially covered". Whereas in version 1.4.10, they were fully covered.

Expected behaviour

viewModelScope.launch { ... } should be marked as fully covered by jacoco for Kotlin 1.4.20.

Actual behaviour

Jacoco report says "2 of 3 branches missed" forviewModelScope.launch { ... } block. So it's only partially covered:

image
@ugurcany ugurcany added the type: bug 🐛 Something isn't working label Nov 25, 2020
@Godin Godin self-assigned this Nov 26, 2020
@Godin Godin added this to Candidates in Current work items via automation Nov 26, 2020
@Godin Godin added this to the 0.8.7 milestone Nov 26, 2020
@Godin Godin added this to To Do in Filtering via automation Dec 16, 2020
This was referenced Jan 5, 2021
Merged
Merged
Filtering automation moved this from To Do to Done Jan 8, 2021
Current work items automation moved this from Candidates to Done Jan 8, 2021
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this issue Jan 12, 2021
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5
86d9266 
JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.
@dariuszkuc dariuszkuc mentioned this issue Jan 12, 2021
Merged
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this issue Jan 14, 2021
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5
ce02f5b 
JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this issue Jan 14, 2021
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5
7c9f4ff 
JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this issue Jan 21, 2021
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5
d02edcf 
JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.
smyrick pushed a commit to ExpediaGroup/graphql-kotlin that referenced this issue Jan 21, 2021
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.2 and Ktor 1.5 (#1007)
a851521 
* [build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5

JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.

* use mavenLocal last and only for graphql-kotlin artifacts

The underlying issue with Gradle being unable to resolve Kotlin platform specific modules was misconfiguration to first look at maven local directory. It was problematic as Gradle uses module metadata to resolve target platform specific (-jvm) modules. Since this metadata is not used by Maven, once Maven integration tests kicked in and downloaded the dependencies, Gradle no longer was able to resolve those platform libs.

See gradle/gradle#15893 for details.

* update to spring boot 2.4.2

* disable flaky tests

Unsure whats causing the race condition on those subscription integration tests when run from GH actions. It appears that some websocket messages are randomly dropped. Cannot reproduce it locally. Disabling the test for now as subscription logic is already covered by tests in spring-server module.

Co-authored-by: Dariusz Kuc <dkuc@expedia.com>
huehnerlady pushed a commit to huehnerlady/graphql-kotlin that referenced this issue Apr 27, 2021
@dariuszkuc @huehnerlady
[build] update to Kotlin 1.4, Spring Boot 2.4.2 and Ktor 1.5 (Expedia…
2485266 
…Group#1007)

* [build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5

JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.

* use mavenLocal last and only for graphql-kotlin artifacts

The underlying issue with Gradle being unable to resolve Kotlin platform specific modules was misconfiguration to first look at maven local directory. It was problematic as Gradle uses module metadata to resolve target platform specific (-jvm) modules. Since this metadata is not used by Maven, once Maven integration tests kicked in and downloaded the dependencies, Gradle no longer was able to resolve those platform libs.

See gradle/gradle#15893 for details.

* update to spring boot 2.4.2

* disable flaky tests

Unsure whats causing the race condition on those subscription integration tests when run from GH actions. It appears that some websocket messages are randomly dropped. Cannot reproduce it locally. Disabling the test for now as subscription logic is already covered by tests in spring-server module.

Co-authored-by: Dariusz Kuc <dkuc@expedia.com>
@Godin Godin mentioned this issue Feb 24, 2022
Closed
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this issue Aug 5, 2022
@dariuszkuc
[build] update to Kotlin 1.4, Spring Boot 2.4.2 and Ktor 1.5 (Expedia…
cb81c07 
…Group#1007)

* [build] update to Kotlin 1.4, Spring Boot 2.4.1 and Ktor 1.5

JaCoCo branch coverage dropped because of jacoco/jacoco#1126, once new version of Jacoco is released we can bump it up again.

* use mavenLocal last and only for graphql-kotlin artifacts

The underlying issue with Gradle being unable to resolve Kotlin platform specific modules was misconfiguration to first look at maven local directory. It was problematic as Gradle uses module metadata to resolve target platform specific (-jvm) modules. Since this metadata is not used by Maven, once Maven integration tests kicked in and downloaded the dependencies, Gradle no longer was able to resolve those platform libs.

See gradle/gradle#15893 for details.

* update to spring boot 2.4.2

* disable flaky tests

Unsure whats causing the race condition on those subscription integration tests when run from GH actions. It appears that some websocket messages are randomly dropped. Cannot reproduce it locally. Disabling the test for now as subscription logic is already covered by tests in spring-server module.

Co-authored-by: Dariusz Kuc <dkuc@expedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Godin Godin

Labels
component: core.filters type: bug 🐛 Something isn't working
Projects
Current work items
  
Done
Filtering
  
Done
Milestone
0.8.7
Development

Successfully merging a pull request may close this issue.

Update filter for suspending lambdas for Kotlin 1.4.20 jacoco/jacoco
2 participants
@Godin @ugurcany