Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The class dumped by jacocoagent with same name will be replaced #225

Merged
merged 1 commit into from
Jul 7, 2014

Conversation

marchof
Copy link
Member

@marchof marchof commented Jul 7, 2014

It could happen in OSGI, class with same name in different bundle.

@marchof
Copy link
Member

marchof commented Jul 3, 2014

Right. Initially I considered adding the class id to the file name.

Would that work for you? What is your use case?

@edisonh
Copy link
Author

edisonh commented Jul 4, 2014

Yes,it would works.
The use case is that getting code coverage in OSGI container which there are n+ apps with difference version in.

@marchof
Copy link
Member

marchof commented Jul 4, 2014

@edisonh I see. But what are using the dumped classes for? Why can't you use the original classes?

@edisonh
Copy link
Author

edisonh commented Jul 4, 2014

Because some classes are dynamically created.

@marchof
Copy link
Member

marchof commented Jul 4, 2014

So would e.g. prefixing the class names work for you?

org/example/app/87a6d0f83ba8455c-MyClass.class

@marchof
Copy link
Member

marchof commented Jul 4, 2014

Remember: You can't use different classes with the same name in the same group of a JaCoCo report. You would need to somehow split them in different bundles.

@edisonh
Copy link
Author

edisonh commented Jul 4, 2014

Yes,it would works.
Thx, ur so nice.

marchof added a commit that referenced this pull request Jul 7, 2014
The class dumped by jacocoagent with same name will be replaced
@marchof marchof merged commit d488b0a into master Jul 7, 2014
@marchof marchof deleted the issue-225 branch August 20, 2014 20:24
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
@Godin Godin added this to the 0.7.2 milestone Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants