Move ASM classes to org.jacoco namespace for jacocoant.jar #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conflicts with other Ant tools.
|
If we use the shade plugin anyways it would be nice to also minimize jacocoant.jar. Unfortunately this didn't work out for me as org.jacoco.ant-nodeps has no code, so the shade plugin sees no classes to start with (which results in an empty jacocoant.jat file). |
|
@marchof I think that relocation and minimization are two different issues, so shouldn't we merge this into master already? |
ghost
assigned
|
@Godin Makes sense! So please merge if you're o.k. with my changes. |
Godin
added a commit
that referenced
this pull request
Nov 10, 2012
Move ASM classes to org.jacoco namespace for jacocoant.jar
Godin
added a commit
that referenced
this pull request
Nov 10, 2012
|
Here is a ticket about minimization - #56 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent updates of ASM we highly depend on specific Ant versions. Users have reported problems with our jacocoant.jar when conflicting with ASM 3.x. Therefore the ASM classes should be moved to the the org.jacoco namespace.