Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more context information when unable to read input during analysis #400

Merged
merged 1 commit into from
May 14, 2016
Merged

Provide more context information when unable to read input during analysis #400

merged 1 commit into from
May 14, 2016

Conversation

Godin
Copy link
Member

@Godin Godin commented May 13, 2016

Add location to IOException thrown from

  1. zip.getNextEntry() in analyzeZip
  2. new GZIPInputStream(input) in analyzeGzip
  3. Pack200Streams.unpack(input) in analyzePack200

@Godin Godin self-assigned this Apr 17, 2016
@Godin Godin added this to the 0.7.7 milestone Apr 17, 2016
@Godin Godin mentioned this pull request Apr 17, 2016
Closed
@Godin
Copy link
Member Author

Godin commented May 13, 2016

@marchof could you please review?

@marchof
Copy link
Member

marchof commented May 14, 2016

@Godin Looks good to me!

P.S.: Nice test cases for broken file formats. Looks like we need a (broken) file format mocking library ;-)

@marchof marchof merged commit fde254d into master May 14, 2016
@Godin Godin deleted the issue-400 branch May 14, 2016 11:43
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Godin Godin

Labels
component: core type: enhancement
Projects
None yet
Milestone
0.7.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof