java.lang.ClassFormatError: Short length on BootstrapMethods in class file #462

Godin · 2016-12-29T12:03:45Z

Posted by @ nikhilnanivadekar :

I am trying to integrate JaCoCo for code coverage of Eclipse Collections

However the build fails with the below error:
java.lang.ClassFormatError: Short length on BootstrapMethods in class file org/eclipse/collections/impl/collector/Collectors2Test

The Collectors2Test.java is 1748 lines long with very small test methods. So, this should not cause any issues as they are well below 64KB method limit of Java.
If I break up this class in two separate files then the build goes through fine. Even after online research I am not able to find a way to fix the Travis build with JaCoCo integration and without splitting the Collectors2Test.java. The build goes through fine in IntelliJ.

The project is setup with Maven build and has surefire plugin. argLine is set in relevant modules where JaCoCo test coverage is run.

GitHub repos and build links:

Eclipse Collections master
Repo
Travis build (passing)
JaCoCo integration with Collectors2Test split in two:
Repo
JaCoCo integration commit
Travis build (passing)
JaCoCo integration with Collectors2Test not split:
Repo
JaCoCo integration commit
Travis build (failing)

Steps to reproduce

Fork and clone the eclipse collections repo
Apply commit 62c5ca4cf04c6ab692f135bf1ef03c1834d5b92a on top of it
Enable Travis integration for your fork.
Push the commit from step 2
Check the unit test build. It generally takes about 5-6 mins to fail.

marchof · 2016-11-17T08:59:32Z

@nikhilnanivadekar could you please provide the original file org/eclipse/collections/impl/collector/Collectors2Test.class (not splittet). Thx,

nikhilnanivadekar · 2016-11-17T10:04:24Z

@marchof It is available here: Collectors2Test.java

native link: https://github.com/eclipse/eclipse-collections/blob/0db19cf63e53dafeb59ac46b582fa0a266c600c5/unit-tests/src/test/java/org/eclipse/collections/impl/collector/Collectors2Test.java

Godin · 2016-11-17T10:48:14Z

@nikhilnanivadekar I think that @marchof was asking for class file. I'm able to reproduce this on my machine, so here is file - class.zip (in zip, because GitHub doesn't allow to attach class directly).

Godin · 2016-11-17T11:25:08Z

@nikhilnanivadekar in the meantime as workaround you can exclude class from the instrumentation:

diff --git i/unit-tests/pom.xml w/unit-tests/pom.xml
index a14a705..10c60ba 100755
--- i/unit-tests/pom.xml
+++ w/unit-tests/pom.xml
@@ -102,6 +102,12 @@
                 <groupId>org.jacoco</groupId>
                 <artifactId>jacoco-maven-plugin</artifactId>
                 <version>${jacoco.plugin.version}</version>
+                <configuration>
+                  <excludes>
+                    <!-- https://github.com/jacoco/jacoco/issues/462 -->
+                    <exclude>org.eclipse.collections.impl.collector.Collectors2Test</exclude>
+                  </excludes>
+                </configuration>
             </plugin>

This does not affect coverage measurement of the main code since this is test file.
Build fully passes on my machine after this modification.

Godin · 2016-11-17T12:45:12Z

@marchof if I'm not mistaken, seems that one bootstrap method is lost during instrumentation

marchof · 2016-11-17T12:49:30Z

@Godin Interesting about this file is that there are >> 300 method references (which compiles to INVOKEDYNAMIC). I assume this is a ASM Bug.

Godin · 2016-11-17T12:58:15Z

Looks like http://forge.ow2.org/tracker/?func=detail&aid=317748&group_id=23&atid=100023

marchof · 2016-11-17T13:20:02Z

@Godin So we have another issue we would need an ASM release for.

Godin · 2016-11-17T17:28:57Z

For the record: I tried JaCoCo with ASM from trunk, which includes fix for the mentioned bug, and it works without exclusion for Eclipse Collections.

nikhilnanivadekar · 2016-11-17T17:33:54Z

Any idea when will the bug fix be released? If it will be soon enough, I would rather wait for it and not add an exclusion.

marchof · 2016-11-17T17:40:02Z

@nikhilnanivadekar Please let's discuss the separate issue on the mailing list.

Unfortunatelly we have no insight in ASM project when they plan the next release.

Godin · 2016-11-17T17:41:26Z

@nikhilnanivadekar so far we are not aware about plans of ASM developers regarding release. And would be better to not mix with other topics here. Thanks for your understanding.

nikhilnanivadekar · 2016-11-17T17:45:24Z

Updated my comment. Thanks!

Godin · 2016-11-17T17:45:38Z

Ouch, didn't noticed Marc's answer.

I'm going to ask in their mailing list about release, however without expectations - previously didn't get response on same question in bug tracker and there seems to be no activity since September.

Godin · 2016-12-10T00:24:36Z

For the record - started thread about release in ASM mailing list: http://mail.ow2.org/wws/arc/asm/2016-12/msg00005.html

Godin · 2016-12-11T17:06:46Z

A note to clarify relation of example given here with description of ASM bug: In presence of Serializable lambdas javac will generate method $deserializeLambda$ . This method is big in given example due to amount of lambdas and its instrumentation triggers recalculation of stack map frames similarly to #177 and ASM looses bootstrap method during this process as described in ASM bug.

Godin · 2016-12-23T14:12:19Z

ASM 5.2 has been released, for upgrade we just need to wait its appearance in Maven Central repository.

@marchof I'm wondering if we should add test for such case to prevent regressions in future, or just update dependency and hope that it won't regress? Could be noted that change in ASM wasn't explicitly covered by tests. 😉 WDYT?

marchof · 2016-12-23T14:21:21Z

@Godin Of course we add a test -- if we're able to create a reproducer e.g. as a validation test! 😎

Godin · 2016-12-29T12:54:36Z

I chose to not add exact example with lambda deserialization as it depends on javac and its internals, and actually not so trivial to also trigger resizing in ASM. But added test that performs a bit of bytecode generation instead. As you can see - it fails before ASM upgrade and passes after. So @marchof could you please review this change?

marchof · 2017-01-04T06:41:03Z

org.jacoco.core.test/src-java8/org/jacoco/core/test/validation/AsmBugTest.java

+	private static int run(final String className, final byte[] bytes)
+			throws ClassNotFoundException, NoSuchMethodException,
+			InvocationTargetException, IllegalAccessException {
+		return (Integer) new ClassLoader() {


We can also use TargetLoader here.

marchof · 2017-01-04T07:45:21Z

org.jacoco.core.test/src-java8/org/jacoco/core/test/validation/AsmBugTest.java

+ * {@code java.lang.ClassFormatError: Short length on BootstrapMethods in class file}
+ * during instrumentation.
+ */
+public class AsmBugTest {


We encountered several ASM bug in the past. So the test name looks a bit too generic for me. Also we tend to name our test cases like what is tested, not what is a bug. I would prefer something like BootstrapMethodReferenceTest.

nikhilnanivadekar · 2017-01-04T16:55:00Z

@Godin Thank you very much for fixing this.
What are the plans for a JaCoCo version release so that I can upgrade it in Eclipse Collections and remove the workaround?

Godin · 2017-01-05T15:09:14Z

@nikhilnanivadekar we can't tell you the exact date yet - there is no strict plan so far.

And as was said in eclipse/eclipse-collections#166 (comment) : EclEmma Eclipse Plugin also needs an update, otherwise execution of tests with coverage in Eclipse using EclEmma will be failing without the current workaround. This update will take some time as we need to not only release JaCoCo, but also promote it as well as new ASM version thru Eclipse CQs into Orbit, followed by a first release of EclEmma under Eclipse umbrella.

All in all my advice for you will be - no need to rush especially that workaround doesn't cause any troubles, a little of patience and stay tuned for announcements about releases 😉

Godin · 2017-01-06T22:22:12Z

For the record: here is a ticket about update for EclEmma - https://bugs.eclipse.org/bugs/show_bug.cgi?id=510059

marchof added type: bug 🐛 Something isn't working component: core labels Nov 17, 2016

Godin changed the title ~~Travis build fails with java.lang.ClassFormatError after integration with JaCoCo~~ java.lang.ClassFormatError: Short length on BootstrapMethods in class file Nov 17, 2016

Godin mentioned this pull request Nov 17, 2016

Integrate JaCoCo for test coverage. eclipse/eclipse-collections#166

Merged

Godin added this to the 0.7.9 milestone Dec 23, 2016

Godin force-pushed the issue-462 branch from a2a2fe4 to a760bb5 Compare December 29, 2016 12:21

Godin self-assigned this Dec 29, 2016

Godin requested a review from marchof December 29, 2016 12:54

Godin force-pushed the issue-462 branch 2 times, most recently from 1df652e to 08ef8a2 Compare December 29, 2016 13:49

(wip) add test

08ef8a2

Godin force-pushed the issue-462 branch from d252d22 to 905087c Compare December 29, 2016 14:06

Godin added 2 commits December 29, 2016 15:07

(wip) upgrade ASM to 5.2

70a2eca

(wip) update changelog

905087c

Godin mentioned this pull request Dec 29, 2016

Frames are re-calculated for large methods #177

Merged

Godin and others added 2 commits January 3, 2017 23:22

Merge branch 'master' into issue-462

7a89eba

Happy New Year 2017!

a2b7945

marchof reviewed Jan 4, 2017

View reviewed changes

Godin added 2 commits January 4, 2017 11:13

(wip) use TargetLoader

f6c43aa

(wip) rename test file

ee78dc2

marchof approved these changes Jan 4, 2017

View reviewed changes

Godin added 2 commits January 4, 2017 12:36

Merge branch 'master' into issue-462

36b8aa9

Merge branch 'master' into issue-462

c50bb77

Godin merged commit b208594 into master Jan 4, 2017

Godin deleted the issue-462 branch January 4, 2017 11:59

jacoco locked and limited conversation to collaborators Jan 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

java.lang.ClassFormatError: Short length on BootstrapMethods in class file #462

java.lang.ClassFormatError: Short length on BootstrapMethods in class file #462

Godin commented Dec 29, 2016 •

edited

Loading

marchof commented Nov 17, 2016

nikhilnanivadekar commented Nov 17, 2016 •

edited

Loading

Godin commented Nov 17, 2016

Godin commented Nov 17, 2016

Godin commented Nov 17, 2016

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016

nikhilnanivadekar commented Nov 17, 2016 •

edited

Loading

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016 •

edited

Loading

nikhilnanivadekar commented Nov 17, 2016

Godin commented Nov 17, 2016

Godin commented Dec 10, 2016 •

edited

Loading

Godin commented Dec 11, 2016 •

edited

Loading

Godin commented Dec 23, 2016

marchof commented Dec 23, 2016

Godin commented Dec 29, 2016

marchof Jan 4, 2017

Godin Jan 4, 2017

marchof Jan 4, 2017

Godin Jan 4, 2017

nikhilnanivadekar commented Jan 4, 2017

Godin commented Jan 5, 2017 •

edited

Loading

Godin commented Jan 6, 2017

java.lang.ClassFormatError: Short length on BootstrapMethods in class file #462

java.lang.ClassFormatError: Short length on BootstrapMethods in class file #462

Conversation

Godin commented Dec 29, 2016 • edited Loading

GitHub repos and build links:

Steps to reproduce

marchof commented Nov 17, 2016

nikhilnanivadekar commented Nov 17, 2016 • edited Loading

Godin commented Nov 17, 2016

Godin commented Nov 17, 2016

Godin commented Nov 17, 2016

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016

nikhilnanivadekar commented Nov 17, 2016 • edited Loading

marchof commented Nov 17, 2016

Godin commented Nov 17, 2016 • edited Loading

nikhilnanivadekar commented Nov 17, 2016

Godin commented Nov 17, 2016

Godin commented Dec 10, 2016 • edited Loading

Godin commented Dec 11, 2016 • edited Loading

Godin commented Dec 23, 2016

marchof commented Dec 23, 2016

Godin commented Dec 29, 2016

marchof Jan 4, 2017

Choose a reason for hiding this comment

Godin Jan 4, 2017

Choose a reason for hiding this comment

marchof Jan 4, 2017

Choose a reason for hiding this comment

Godin Jan 4, 2017

Choose a reason for hiding this comment

nikhilnanivadekar commented Jan 4, 2017

Godin commented Jan 5, 2017 • edited Loading

Godin commented Jan 6, 2017

Godin commented Dec 29, 2016 •

edited

Loading

nikhilnanivadekar commented Nov 17, 2016 •

edited

Loading

nikhilnanivadekar commented Nov 17, 2016 •

edited

Loading

Godin commented Nov 17, 2016 •

edited

Loading

Godin commented Dec 10, 2016 •

edited

Loading

Godin commented Dec 11, 2016 •

edited

Loading

Godin commented Jan 5, 2017 •

edited

Loading