No need to sign JARs using maven-jarsigner-plugin #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Godin I found more occurences for signing which probably should be removed:
As discussed on ML: We mention this in changes.html |
|
@marchof should be fine now |
marchof
reviewed
Dec 8, 2016
| @@ -48,6 +48,12 @@ | |||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/427">#427</a>).</li> | |||
| </ul> | |||
|
|
|||
| <h3>Non-functional Changes</h3> | |||
| <ul> | |||
| <li>Stop signing release JARs | |||
There was a problem hiding this comment.
From the user's POV shouldn't that read: "Released JaCoCo JARs are not signed any more. Signed versions of JaCoCo are now available from the Eclipse Orbit project".
marchof
approved these changes
Dec 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use case for signing JaCoCo artifacts was the EclEmma plugin. Next release of EclEmma under Eclipse Foundation umbrella will use JaCoCo bundles from Eclipse Orbit, which signed by eclipse.org anyway. So that no need to sign anymore during our releases.
Initial discussion: https://groups.google.com/d/msg/jacoco-dev/hTLvWPXqaUg/fKoDA3zqBAAJ