Method Analyzer.analyzeClass(InputStream, String) as others should provide context information when unable to read input during analysis #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
reviewed
May 29, 2017
| @@ -41,9 +41,6 @@ private Java9Support() { | |||
| */ | |||
| public static byte[] readFully(final InputStream is) | |||
| throws IOException { | |||
| if (is == null) { | |||
There was a problem hiding this comment.
@Godin Why do we need this check specifically here? I think all other APIs like analyzeAll() will result in a NPE for a null InputStream. Which looks ok for me.
There was a problem hiding this comment.
@marchof I guess that you misread change: it doesn't add check, but removes it exactly because we don't need it - indeed in all places for a null InputStream we throw NullPointerException instead of IllegalArgumentException, also this condition wasn't covered by tests, so I took opportunity to remove it in this PR.
There was a problem hiding this comment.
@Godin Sure, my bad. You actually fixed the issue - thanks!!!
marchof
approved these changes
May 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was forgotten in #400