For Java 9 add "Automatic-Module-Name" to manifests of JAR files #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no doubts about module names and their usefulness for the following JARs:
org.jacoco.corefororg.jacoco.core-<VERSION>.jarorg.jacoco.reportfororg.jacoco.report-<VERSION>.jarorg.jacoco.antfororg.jacoco.ant-<VERSION>.jarAlso seems that module name is useful for agent (see #545). While there might be debate about its name and name for
org.jacoco.agent-<VERSION>.jarthat contains first one as a resource and whose existence might also be a subject of discussion, we can start withorg.jacoco.agent.rtforjacocoagent.jar- consistent with names of packages inside JARs.Should also be noted that I don't think that existence of class
com.vladium.emma.RTin this JAR is a problem - anyway can be solved later when/if it will turn out to be a problemorg.jacoco.agentfororg.jacoco.agent-<VERSION>.jar- consistent with name of package inside JAR and OSGi bundle name