-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ASM to 6.2 #706
Upgrade ASM to 6.2 #706
Conversation
9304fab
to
e3486e8
Compare
@marchof could you please have a look? I didn't update changelog to first discuss below points. All changes in our tests, except one about Should be noted that some regressions were already found in ASM 6.2, however to me seems that JaCoCo can't be affected by them, but might be worth double-checking - AFAIK as of 2 July 2018 from the list of issues (https://gitlab.ow2.org/asm/asm/issues) and changes after ASM 6.2 (https://gitlab.ow2.org/asm/asm/compare/ASM_6_2...master):
And seems that while https://gitlab.ow2.org/asm/asm/issues/317833 was fixed after 6.2, problem was already there with ASM 6.0, also we don't use Also should be noted that ASM 6.2 contains experimental support for the upcoming JDK 11 features (nest mates JEP-181 and ConstantDynamic JEP-309) - see https://mail.ow2.org/wws/arc/asm/2018-05/msg00004.html Furthermore While seems that this allows to use our
Also even if JDK 11 is now in Rampdown Phase One, AFAIK there is no strong guarantees that bytecode won't change, and this is also why support for JDK 11 features is experimental in ASM 6.2. IMO the best what we can do - is also "experimental support", i.e. without any guarantees. WDYT? In any case, I would prefer to separate ASM update from JDK 11 support. |
@Godin +1 for adding experimental JDK 11 support in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@marchof and just to be sure - what about known regressions in ASM 6.2? do you agree with my analysis that they don't affect us? any concerns about possible others, given that 6.1 was a massive refactoring? |
@Godin I agree with you that the regressions do not affect usage in JaCoCo. And hey, our tests are green ;) |
@marchof well, as history shows - our tests are not totally ehaustive and bulletproof 😉 I updated changelog and will do the merge. Thank you for review! |
@marchof in fact while
is correct, |
For the record: ticket to upgrade ASM in Eclipse Orbit - https://bugs.eclipse.org/bugs/show_bug.cgi?id=536922 |
No description provided.