New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require at least Maven 3.0 for jacoco-maven-plugin #821
Conversation
@slachiewicz thank you for your contribution - it is good to know about connection between #194 and #314 👍 However #314 was not in our short-term plans and #194 is definitely not enough to justify #314 - Maven is not the only way of JaCoCo usage. Is there a chance that you can work on a way to resolve this without #314 ? If not, then we would prefer to close this incomplete PR. |
Unfortunately, I don't see any reasonable solution, because maven-reporting-impl is required for reporting functionality. |
In fact sounds strange that #194 requires #314 , because according to page https://maven.apache.org/docs/history.html Maven 3.0 was still on Java 5 😉 @slachiewicz are you sure that update of |
Thx for the hint - simplified version added in 592d68e and sample project from our issue https://jira.apache.org/jira/browse/MDEP-82 works fine. |
@marchof are you ok if in upcoming release we drop support of Maven 2.2.1 (last release in November 2009) ? If so, then I'll take care of further testing, review of documentation, etc to finalize this PR. |
@Godin Absolutely! |
@marchof I updated documentation and IMO this is ready to be merged. |
Fixes #194
Tests with Java 5 failed due to artifact doxia-site-renderer-1.7.4 compiled for Java 6 (from maven-reporting-impl:jar:3.0.0) - blocked by #314