Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least Maven 3.0 for jacoco-maven-plugin #821

Merged
merged 1 commit into from Jan 10, 2019
Merged

Require at least Maven 3.0 for jacoco-maven-plugin #821

merged 1 commit into from Jan 10, 2019

Conversation

slachiewicz
Copy link
Contributor

Fixes #194

Tests with Java 5 failed due to artifact doxia-site-renderer-1.7.4 compiled for Java 6 (from maven-reporting-impl:jar:3.0.0) - blocked by #314

@Godin
Copy link
Member

Godin commented Jan 8, 2019

@slachiewicz thank you for your contribution - it is good to know about connection between #194 and #314 👍 However #314 was not in our short-term plans and #194 is definitely not enough to justify #314 - Maven is not the only way of JaCoCo usage. Is there a chance that you can work on a way to resolve this without #314 ? If not, then we would prefer to close this incomplete PR.

@Godin Godin added the feedback pending Further information is requested label Jan 8, 2019
@slachiewicz
Copy link
Contributor Author

Unfortunately, I don't see any reasonable solution, because maven-reporting-impl is required for reporting functionality.
@khmarbaise maybe You have an idea?

@Godin
Copy link
Member

Godin commented Jan 8, 2019

In fact sounds strange that #194 requires #314 , because according to page https://maven.apache.org/docs/history.html Maven 3.0 was still on Java 5 😉 @slachiewicz are you sure that update of maven-reporting-impl is needed?

@slachiewicz
Copy link
Contributor Author

Thx for the hint - simplified version added in 592d68e and sample project from our issue https://jira.apache.org/jira/browse/MDEP-82 works fine.
So no need to drop Java 5 support.

@Godin
Copy link
Member

Godin commented Jan 9, 2019

@marchof are you ok if in upcoming release we drop support of Maven 2.2.1 (last release in November 2009) ? If so, then I'll take care of further testing, review of documentation, etc to finalize this PR.

@marchof
Copy link
Member

marchof commented Jan 9, 2019

@Godin Absolutely!

@Godin Godin self-requested a review January 9, 2019 18:13
@Godin Godin removed the feedback pending Further information is requested label Jan 9, 2019
@Godin Godin added this to the 0.8.3 milestone Jan 9, 2019
@Godin Godin added this to Implementation in Current work items via automation Jan 9, 2019
@Godin Godin moved this from Implementation to Review in Current work items Jan 9, 2019
@Godin Godin self-assigned this Jan 9, 2019
@Godin Godin changed the title Migrate to Maven Core 3.0+ Require at least Maven 3.0 for jacoco-maven-plugin Jan 9, 2019
@Godin
Copy link
Member

Godin commented Jan 9, 2019

@marchof I updated documentation and IMO this is ready to be merged.

@Godin Godin requested a review from marchof January 9, 2019 22:35
@marchof marchof merged commit db5fefe into jacoco:master Jan 10, 2019
Current work items automation moved this from Review to Done Jan 10, 2019
@slachiewicz slachiewicz deleted the Maven3 branch January 11, 2019 20:57
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

Revoke support for Maven 2.2.*
3 participants