Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A little enhancement of report #1303

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

A little enhancement of report #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7aae925
Update README.md
the-end-sea-of-the-world Apr 22, 2022
8b9a267
Check the path of xml and csv and create if it does not exist
the-end-sea-of-the-world Apr 23, 2022
9d600d5
Merge remote-tracking branch 'origin/master'
the-end-sea-of-the-world Apr 23, 2022
af76da5
Update README.md
the-end-sea-of-the-world Apr 23, 2022
af4861f
Use java.io.File API to get the parent file.
the-end-sea-of-the-world Apr 26, 2022
b31af68
Add JUnit tests and a demo used in the tests.
the-end-sea-of-the-world Apr 26, 2022
4bae2df
Merge remote-tracking branch 'origin/master'
the-end-sea-of-the-world Apr 26, 2022
fa520dc
Modify JUnit tests and add a method createParent().
the-end-sea-of-the-world May 2, 2022
9cbcc74
delete unnecessary comments.
the-end-sea-of-the-world May 2, 2022
a3a2040
adjust the format.
the-end-sea-of-the-world May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions org.jacoco.cli.test/src/org/jacoco/cli/internal/commands/ReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,18 @@ public void should_create_xml_report_when_xml_option_is_provided()
assertTrue(xml.isFile());
}

@Test
public void should_create_xml_report_when_xml_option_is_provided_and_the_path_is_not_exist()
throws Exception {
File xml = new File(new File(tmp.getRoot(), "xml"), "coverage.xml");

execute("report", "--classfiles", getClassPath(), "--xml",
xml.getAbsolutePath());

assertOk();
assertTrue(xml.isFile());
}

@Test
public void should_create_csv_report_when_csv_option_is_provided()
throws Exception {
Expand All @@ -110,6 +122,18 @@ public void should_create_csv_report_when_csv_option_is_provided()
assertTrue(csv.isFile());
}

@Test
public void should_create_csv_report_when_csv_option_is_provided_and_the_path_is_not_exist()
throws Exception {
File csv = new File(new File(tmp.getRoot(), "csv"), "coverage.csv");

execute("report", "--classfiles", getClassPath(), "--csv",
csv.getAbsolutePath());

assertOk();
assertTrue(csv.isFile());
}

@Test
public void should_create_html_report_when_html_option_is_provided()
throws Exception {
Expand Down
9 changes: 9 additions & 0 deletions org.jacoco.cli/src/org/jacoco/cli/internal/commands/Report.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,24 @@ private void writeReports(final IBundleCoverage bundle,
visitor.visitEnd();
}

private void createParent(final File file) {
final File folder = file.getParentFile();
if (!folder.exists()) {
final boolean dr = folder.mkdirs();
}
}

private IReportVisitor createReportVisitor() throws IOException {
final List<IReportVisitor> visitors = new ArrayList<IReportVisitor>();

if (xml != null) {
createParent(xml);
final XMLFormatter formatter = new XMLFormatter();
visitors.add(formatter.createVisitor(new FileOutputStream(xml)));
}

if (csv != null) {
createParent(csv);
final CSVFormatter formatter = new CSVFormatter();
visitors.add(formatter.createVisitor(new FileOutputStream(csv)));
}
Expand Down