Add test of ASM bug 317792 #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
requested changes
Oct 9, 2017
| final byte[] bytes = instrumenter.instrument(cw.toByteArray(), ""); | ||
|
|
||
| final TargetLoader targetLoader = new TargetLoader(); | ||
| final Class outer = targetLoader.add(ResizeInstructionsTest.class, |
There was a problem hiding this comment.
@Godin Raw Class types give a compiler warning, Class<?> fixes the issue.
| final TargetLoader targetLoader = new TargetLoader(); | ||
| final Class outer = targetLoader.add(ResizeInstructionsTest.class, | ||
| TargetLoader.getClassDataAsBytes(ResizeInstructionsTest.class)); | ||
| final Class inner = targetLoader.add(Inner.class, bytes); |
There was a problem hiding this comment.
@Godin Same here: Raw Class types give a compiler warning, Class<?> fixes the issue.
| * Test of ASM bug | ||
| * <a href= "https://gitlab.ow2.org/asm/asm/issues/317630">#317630</a> that | ||
| * caused {@code java.lang.ClassNotFoundException}. | ||
| */ |
There was a problem hiding this comment.
@Godin For consistency this test should also have a descriptive method name.
marchof
approved these changes
Oct 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitlab.ow2.org/asm/asm/issues/317792