Question mark in filter expressions should match exactly one character #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
requested changes
Apr 13, 2018
| @@ -33,6 +33,12 @@ <h3>Fixed Bugs</h3> | |||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/667">#667</a>).</li> | |||
| </ul> | |||
|
|
|||
| <h3>API Changes</h3> | |||
There was a problem hiding this comment.
IMO we don't change API, this is just a fix for bug, no matter how long this bug was here.
Godin
changed the title
Godin
approved these changes
Apr 15, 2018
|
LGTM 👍 for readability only changed sign "?" on words "question mark" in changelog, hope you don't mind. |
|
@Godin Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671