Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused constants in XMLFormatter #708

Merged
merged 1 commit into from Jul 5, 2018
Merged

Remove unused constants in XMLFormatter #708

merged 1 commit into from Jul 5, 2018

Conversation

marchof
Copy link
Member

@marchof marchof commented Jul 5, 2018 •
edited

It was probably to late in the night when I rebased #652 on master.

@marchof marchof self-assigned this Jul 5, 2018
@marchof
Remove unused constants.
edd7c5d 
Regression introduced by refactoring in #652.
@marchof marchof requested a review from Godin July 5, 2018 14:11
@marchof
Copy link
Member Author

marchof commented Jul 5, 2018

@Godin May I ask you to have a look again?

Reminder to myself: Don't rebase after midnight.

@Godin Godin merged commit c8b8c9d into master Jul 5, 2018
@Godin Godin deleted the issue-708 branch July 5, 2018 14:36
@Godin
Copy link
Member

Godin commented Jul 5, 2018

@marchof do not reproach yourself, also probably I was too fast with review 😉 seen unused fields, but right after merge.

BTW looking at #702 and #652, seems that while we do check correctness of DOCTYPE in html report, we do not have such test for xml report, IMO worth to be added.

@Godin Godin added this to the 0.8.2 milestone Jul 5, 2018
@jacoco jacoco locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Godin Godin Godin approved these changes

Assignees

@marchof marchof

Labels
component: report
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marchof @Godin