Modernize JaCoCo Report design #756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchof
changed the title
Godin
requested changes
Oct 23, 2018
| @@ -141,7 +143,7 @@ private static void breadcrumbParent(final ReportPage page, | |||
| if (page != null) { | |||
| breadcrumbParent(page.parent, div, base); | |||
| div.a(page, base); | |||
| div.text(" > "); | |||
| div.text(BREADCRUMP_SEPARATOR); | |||
There was a problem hiding this comment.
IMO and SonarSource designer @thibaudeberwein agree with me that previously was better:
|
Idea of @Godin: Why not showing totals at the top? This is the primary information. If shown in headers no scrolling is required even for long lists of elements to see totals. |
|
Yes I saw this as well when playing around with the CSS. This PR has been around for years. Any plans of bringing it into the mainline branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adjusting some CSS the look & feel can be improved a bit: