Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neighborsOf predicate processors in filter plugin should accept multiple ids. #1009

Closed
senakafdo opened this issue Jan 28, 2019 · 4 comments
Closed
Labels

Comments

@senakafdo
Copy link

The current neighborsOf predicate processor introduced in #325, only provides filtering on a per-node basis. When it is required to display neighbors of not just one but several nodes, the complexity of the operation becomes O(n2). This is not particularly useful for very large graphs with many thousands of nodes.

A simple improvement to the neighborsOf predicate processor would be for it to also accept an array of ids.

@stale
Copy link

stale bot commented Oct 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 8, 2021
@stale stale bot closed this as completed Oct 23, 2021
@senakafdo
Copy link
Author

The stale bot is not particularly helpful. @jacomyal what's the best way forward? Do you need a PR?

@Yomguithereal
Copy link
Collaborator

Hello @senakafdo. Sigma v1 has been deprecated and won't be maintained anymore. This said, version 2 is now out, and in v2, since sigma now relies on graphology as its graph representation, the bug you are mentioning is no longer an issue as neighbor handling should very straightforward and efficient now.

@senakafdo
Copy link
Author

@Yomguithereal ah! nice. I should have kept my eyes wide open. I will get the refs updated. Love the new version - excellent job there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants