Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dragNodes mishandles offset within node, first drag event causes discontinuous jump #551

Closed
ryan-williams opened this issue Apr 23, 2015 · 1 comment
Closed

dragNodes mishandles offset within node, first drag event causes discontinuous jump #551

ryan-williams opened this issue Apr 23, 2015 · 1 comment
Labels
wontfix

Comments

@ryan-williams
Copy link

If I start a drag toward the edge of a node, the first pixel of mouse-drag causes the node's position to jump so that it is centered around the mouse cursor:

Here's a more obvious screencast with large nodes:

And a higher-res movie illustrating the phenomenon.

Without having looked at the code, it seems like some amount of accounting for the initial intra-node offset of the mouse-drag-start is not being done.
ryan-williams added a commit to ryan-williams/sigma.js that referenced this issue Apr 24, 2015
@ryan-williams
fix jumpiness on initial node-drag event
9b8c6ab 
store the offset of each drag-start from the dragged-node's
coordinates; offset each update of the node's position by that offset.

fixes jacomyal#551
@ryan-williams ryan-williams mentioned this issue Apr 24, 2015
Closed
ryan-williams added a commit to ryan-williams/sigma.js that referenced this issue Apr 24, 2015
@ryan-williams
fix jumpiness on initial node-drag event
116149b 
store the offset of each drag-start from the dragged-node's
coordinates; offset each update of the node's position by that offset.

fixes jacomyal#551
@stale
Copy link

stale bot commented Oct 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 9, 2021
@stale stale bot closed this as completed Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix jumpiness on initial node-drag event ryan-williams/sigma.js
1 participant
@ryan-williams