Pyramid rewrite #13
Closed
Pyramid rewrite #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
Rewrite of the pyramid example
When I looked at the code in
pyramid.py, I saw you struggled with the arguments of thefig.add_axesfunction. Because the dimensions [left, bottom, width, height] of the new axes are in fractions of figure width and height. Your code performs complex calculations for determining the proper values of left, bottom, width and height.What if we could position the inset images of the zernike polynomials directly at their right position
(m, n)?Using the function
inset_axes, it is possible to use an absolute position instead of a position relative to the main figure. This massively simplifes your code.You can learn more about the
inset_axesfunction herePyramid image