-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMUNICA: troubles using quadstore-comunica with rollup #109
Comments
Hello @retog! I'm not aware of any project using quadstore with rollup, at the moment. However, this has likely something to do with our custom configuration of Comunica. I have explicitly excluded the
|
Could be related to comunica/comunica#656 ? |
Hello @jacoscaz! I get the error as soon as I add the import to my code
I don't need to create an instance or a call a function for the error to appear. |
comunica/comunica#656 manifests in an error at build time, here I get the error at runtime in the browser or in the electron app, so I don't see a relation between the two problems. A near minimal project showing this problem: https://github.com/retog/rollup-comunica/tree/quadstore (the |
While working on our configuration of comunica I noticed that Webpack, unless explicitly instructed not to do so in its This seems to happen with both Webpack v4.x and v5.x and I only managed to work around it (rather than fix it) using externals. I am still not sure as to whether there's a bug somewhere or whether it's me doing something wrong in Webpack's configuration and/or in Comunica's. There might be something common to these:
@retog: given that we publish our Comunica configuration to NPM already bundled, what you might want to try is to tell Rollup to use See also: @rubensworks any ideas? Just FYI, I'm feeling a little under the weather and I won't be as responsive over the next day or two. Please tag me again if the conversation continues and I don't come back to it within a few days. |
Thanks for your suggestion. Unfortunately, I don't know how to do this. I tried manually editing
|
As a non-user of Rollup, this looks like something that should fix the error, as Rollup seems to be using the Webpacked bundle, which is bound to cause problems. In any case, I also suspect comunica/comunica#656 will pop up here again. |
Why, though? The bundle included in @retog, I've made a couple of little changes to partially test the above. Could you please try to use commonjs({
ignore: id => id.startsWith('_webpack_ignored_')
}), No need to change the |
Hi @jacoscaz, I've tried with the changes you suggested but I'm still getting:
|
Hi @retog! Just FYI, I'm testing with Rollup myself to see whether I can conjure a configuration that correctly bundles |
I've tried using webpack, and getting similar errors:
|
Hello @retog. What a coincidence! I'm working on a reference repository for bundling quadstore with Webpack right now and will have that running within the next hour :) |
Hello again. Let's start with the bad news first. I haven't been able to make That said, the good news: I've created a whole new repository that will act as a reference point for how to use Webpack with quadstore: https://github.com/beautifulinteractions/node-quadstore-webpack-bundle . It contains a prebuilt UMD bundle and the Webpack configuration that is used to built it. Hopefully this will make your life easier - let me know how it goes! |
Hi @jacoscaz, that's a good news indeed! With your webpack configuration, it was easy to get it working. Thanks a lot! |
Happy to hear that @retog . I'll close this issue as we have no plans to support Rollup in the short term and we do provide an alternative for browser-side usage. By the way, I'd be happy to hear your use-case for |
Trying to use Quadstore (v7.0.1-alpha.9) with a rollup project I get errors like the following:
or
Is there any known project succesfully using Quadstore with rollup?
The text was updated successfully, but these errors were encountered: