Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiThreadedExecutionTestCase fails nondeterministically on Travis #5

Closed
jacquev6 opened this issue Jan 8, 2018 · 2 comments
Closed

Comments

@jacquev6
Copy link
Owner

jacquev6 commented Jan 8, 2018

https://travis-ci.org/jacquev6/ActionTree/jobs/326011923#L731
https://travis-ci.org/jacquev6/ActionTree/jobs/314271763#L733
https://travis-ci.org/jacquev6/ActionTree/jobs/313910394#L733
https://travis-ci.org/jacquev6/ActionTree/jobs/312889258#L733
https://travis-ci.org/jacquev6/ActionTree/jobs/310802825#L756

All tests in MultiThreadedExecutionTestCase seem to fail from time to time. This seems to happen only on Python 3. I was not able to reproduce it on my desktop computer.

@jacquev6
Copy link
Owner Author

jacquev6 commented Jan 8, 2018

Testing multi-threaded code using time.sleep to synchronize threads is not robust. This seemed reliable enough when I wrote the test code, but this proves it's not.

I'll first make the delay 10 times longer on Travis to verify that the issue is indeed in the testing framework and not in the library. Then I'll work on a more robust testing strategy.

jacquev6 added a commit that referenced this issue Jan 8, 2018
@jacquev6
Copy link
Owner Author

jacquev6 commented Feb 9, 2018

"Then I'll work on a more robust testing strategy": done.

@jacquev6 jacquev6 closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant