Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can now specify assignee as a string #218

Merged
merged 3 commits into from Dec 24, 2013
Merged

Conversation

dfarr
Copy link
Contributor

@dfarr dfarr commented Dec 17, 2013

Issue #214

When calling pygithub for calls associated with assignees you can now simply pass a string instead of a NamedUser object. This applies to the following methods:

  • issue.edit()
  • repo.create_issue()
  • repo.get_issues()
  • repo.has_in_assignees()
  • repo.has_in_collaborators()
  • repo.remove_from_collaborators()
  • repo.add_to_collaborators()

When calling pygithub for calls associated with assignees you can now simply pass a string instead of a NamedUser object. This applies to the following methods:
- issue.edit()
- repo.create_issue()
- repo.get_issues()
- repo.has_in_assignees()
- repo.has_in_collaborators()
- repo.remove_from_collaborators()
- repo.add_to_collaborators()
@jacquev6
Copy link
Member

Great job, with tests and doc and all! Thanks! I will integrate that next week-end or before.

@ghost ghost assigned jacquev6 Dec 17, 2013
jacquev6 added a commit that referenced this pull request Dec 24, 2013
Can now specify assignee as a string
@jacquev6 jacquev6 merged commit fefb13d into PyGithub:develop Dec 24, 2013
@jacquev6
Copy link
Member

Thank you very much for your contribution, it is in PyGithub 1.23.0!

@dfarr
Copy link
Contributor Author

dfarr commented Dec 24, 2013

Awesome!

@jacquev6 jacquev6 added the v1 label Mar 2, 2014
@dfarr dfarr added the v1 label Mar 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants