Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing when a web server is running in localhost #11

Merged
merged 1 commit into from
Aug 10, 2012

Conversation

miquelruiz
Copy link

Hi,

Just saw you published version 0.19. When I installed it, it failed because a web server is running in the server...

This patch will fix the issue, and it also checks for some more errors.

Hope it helps. Regards,
Miquel Ruiz

 - Check if the Content-Type of the HTTP response is 'text/xml'.
 - Set an XML with errors when the response fails with a 500 or 300 code.
 - Since the error message can contain XML, it is now wrapped in a CDATA.
 - Check for XML parsing errors.
jadeallenx added a commit that referenced this pull request Aug 10, 2012
Tests failing when a web server is running in localhost
@jadeallenx jadeallenx merged commit 010c808 into jadeallenx:master Aug 10, 2012
@jadeallenx
Copy link
Owner

I'll spin up a new release tonight. Thanks for the patches! I think they're great.

@jadeallenx
Copy link
Owner

I had test failures on t/02_live.t

$ make test
PERL_DL_NONLAZY=1 /Users/mallen/perl5/perlbrew/perls/perl-5.16.0/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00_use.t t/01_init.t t/02_live.t t/03_failing_calls.t
t/00_use.t ............ ok     
t/01_init.t ........... ok   
t/02_live.t ........... 3/25 
#   Failed test 'The object isa Net::Amazon::EC2::KeyPair'
#   at t/02_live.t line 40.
#     The object isn't a 'Net::Amazon::EC2::KeyPair' it's a 'Net::Amazon::EC2::Errors'
Can't locate object method "key_name" via package "Net::Amazon::EC2::Errors" at t/02_live.t line 41.
# Looks like you planned 25 tests but ran 3.
# Looks like you failed 1 test of 3 run.
# Looks like your test exited with 2 just after 3.
t/02_live.t ........... Dubious, test returned 2 (wstat 512, 0x200)

So I reverted the patch but re-released with a slightly modified t/03_failing_calls.t to stop the test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants