Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm support? #27

Closed
sebastiendan opened this issue Jun 30, 2016 · 8 comments
Closed

Npm support? #27

sebastiendan opened this issue Jun 30, 2016 · 8 comments

Comments

@sebastiendan
Copy link

Hi,

Any chance of porting your module as an npm package?
I'd like to get rid of bower and use only npm for external libraries (mainly because I'm playing with Webpack which is better used with npm modules only).

Thanks!

@jadjoubran
Copy link
Owner

Hi @sebastiendan
Yes sure! Would you be able to send a PR? Or at least point me in the right direction to make it also exportable for npm modules (never done this before)

Thanks!

@sebastiendan
Copy link
Author

No pb, I've never done it either but will try soon.
Should be pretty straightforward from this:

https://docs.npmjs.com/getting-started/creating-node-modules

@sebastiendan
Copy link
Author

Any news on this? I actually did my first npm module a few days ago, it really is easy and takes no more than 5 min.

Thanks for your work!

@jadjoubran
Copy link
Owner

Oh I thought you were going to send a PR
Let me know if you can't, so I'll do it

@sebastiendan
Copy link
Author

Actually you just have to check information in package.json is correct and then run npm publish. It has to be done with your npm account otherwise it won't be under your control, so there's nothing much I can do with a PR :)

@jadjoubran
Copy link
Owner

Oh that's right! I thought there something that needed to be fixed in the package.json
It's published now here
Let me know if it doesn't work

@sebastiendan
Copy link
Author

Works like a charm, thank you!
Nevertheless I have 2 suggestions:

  • You should update your readme
  • I don't know if this is the best practise but in package.json I would config main as minified version of your script. Anyway your script is very light so it's ok as it is now.

Thank you for prompt reply and change on this!

Cheers!

jadjoubran added a commit that referenced this issue Jul 9, 2016
@jadjoubran
Copy link
Owner

Thanks!
Fixed in 0.4.4
Also moved express from dependencies to devDependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants