Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdl-text-field : keep <input> to conserve the possibility to use some attribut as "list" #9

Open
Piou2fois opened this issue Aug 9, 2015 · 4 comments

Comments

@Piou2fois
Copy link
Contributor

With the current directive mdl-text-field there is no possibility to have the "list" attribute for the input or "type".
Best would be that the directive must include the input to be able to do so.
Check Lumx project that gives that possibility for example.

@jadjoubran
Copy link
Owner

Indeed this is important but I need a solution that works for all scenarios.. People might need to add a disabled attribute or maybe aria attributes.. so I just asked on stackoverflow

@Piou2fois
Copy link
Contributor Author

Another point, don't forget the "textarea" in place of the input.

@jadjoubran
Copy link
Owner

type now works through PR #16

jadjoubran added a commit that referenced this issue Dec 31, 2015
@jadjoubran
Copy link
Owner

Hi @Piou2fois
I found a much better way for text fields, buttons, radios, etc..
I just implemented the text fields for now. Here's what changed:

mdl-text-field is no longer an element directive. It's become an attribute directive, allowing full control over the input element without having to worry about MDL's boilerplate.

e.g.:

<input type="email" placeholder="Email" ng-model="vm.email" ng-disabled="vm.hasEmail" mdl-text-field/>

Let me know if you (or anyone) can help with PR for the rest (checkboxes, radios, buttons)
And let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants