Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle switch helper should add class param to its container #341

Merged
merged 3 commits into from Sep 28, 2016
Merged

Toggle switch helper should add class param to its container #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c4b572
Toggle switch helper should pass class attribute to its container
Stanton Sep 28, 2016
a142119
Add test case for toggle switch class attribute
Stanton Sep 28, 2016
7674482
Merge branch 'CMS-3879_ui-hotfixes' of https://github.com/jadu/pulsar…
Stanton Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/unit/Jadu/Pulsar/Twig/Macro/Fixtures/form/toggle_switch-class.html
View file
Open in desktop
@@ -0,0 +1,9 @@
<div class="form__group foo form__group--toggle">
<label for="toggletest" class="control__label">Toggle</label>
<div class="controls">
<input label="Toggle" id="toggletest" type="checkbox" class="form__control toggle-switch" />
<label for="toggletest" class="control__label toggle-switch-label">
<span class="hide">Toggle</span>
</label>
</div>
</div>
10 changes: 10 additions & 0 deletions tests/unit/Jadu/Pulsar/Twig/Macro/Fixtures/form/toggle_switch-class.html.twig
View file
Open in desktop
@@ -0,0 +1,10 @@
{% extends '@cssTests/visual-regression-layout.html.twig' %}
{% block body %}
{{
form.toggle_switch({
'class': 'foo',
'label': 'Toggle',
'id': 'toggletest'
})
}}
{% endblock %}
2 changes: 1 addition & 1 deletion views/pulsar/v2/helpers/form.html.twig
View file
Open in desktop
Expand Up @@ -1803,7 +1803,7 @@ data-* | string | Data attributes, eg: `'data-foo': 'bar'`
'parent': options
|only('bare class error guidance guidance-container help id label required')
|merge({
'class': 'form__group--toggle'
'class': options.class|default ~ ' form__group--toggle'
}),
'inputs': [toggle]
})
Expand Down