-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to get stats for current season #52
Comments
@AnkitPatanaik thanks for reporting this issue It looks like Basketball Reference added the This is the first time I've seen this position value used for a player's season totals (usually, the multi-position values are used when a player has played multiple positions across multiple teams). #53 should fix this - I'll close this issue when the patch version has been published to PyPi. |
Awesome! Thanks a lot :) |
Resolves #52 - Jimmy Butler's 2018 Phildelphia 76ers Season Totals include the position value `F-G`. Normally, it's seemed that a player's season total position values for a particular team are limited to a single position. Only when a player has played multiple positions for multiple teams over a given season are multiple positions indicated for that player, and only for the player's overall season total row. Going forward, it might be better to parse that field as a list, if this trend continues. However, this would be a breaking change and would need to be a major version upgrade.
@AnkitPatanaik After installing |
Hey @jaebradley, I tried install version 3.1.1 but pip was unable to find the updated version. Maybe I'm doing something wrong?
EDIT: looks like I had an outdated version of pip |
It looks like there are some other positions that are not accounted for:
I would presume there might be combinations like "F-C" and "G" as well but I am yet to confirm |
When trying to make a call getting data for the current season (season ending in 2019), I receive the following error:
The text was updated successfully, but these errors were encountered: