Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing positions, new patch version, update tests #55

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented Nov 18, 2018

Add the "F", "G-F", "F-C", "G" positions.

Hopefully, resolves #54

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #55 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #55     +/-   ##
========================================
+ Coverage   93.69%   93.8%   +0.1%     
========================================
  Files          10      10             
  Lines         238     242      +4     
  Branches       27      27             
========================================
+ Hits          223     227      +4     
  Misses         11      11             
  Partials        4       4
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
basketball_reference_web_scraper/data.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cfc0b...bcf50ec. Read the comment docs.

@jaebradley jaebradley merged commit 2bf0a26 into master Nov 18, 2018
@jaebradley jaebradley deleted the fix/positions branch November 18, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant