feat(passenger-count): specify number of passengers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaebradley
reviewed
Apr 21, 2018
| import inquirer from 'inquirer'; | ||
|
|
||
| const isValidPassengerCount = (passengerCount) => { | ||
| if (!Number.isNaN(parseFloat(passengerCount)) |
There was a problem hiding this comment.
Maybe using the is-number npm library will create less overhead?
There was a problem hiding this comment.
Yeah, I was just using the convention in selectMaximumPrice.js. Maybe it's worth using is-number there, too.
There was a problem hiding this comment.
jaebradley
reviewed
Apr 21, 2018
| && parseFloat(passengerCount) >= 1) { | ||
| return true; | ||
| } | ||
| return 'Please enter at least one passenger'; |
There was a problem hiding this comment.
Maybe Please enter a positive number of passengers?
|
Logic looks good, can you add screenshots for verifying that this works locally? |
jaebradley
reviewed
Apr 25, 2018
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "flights-searcher-cli", | |||
| "name": "flights-search-cli", | |||
There was a problem hiding this comment.
There shouldn't be a package-lock.json change without a corresponding change to package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify the number of passengers for a flight, defaulting to 1 (see #4)