Merge pull request #119 from jaebradley/even-moar-linting

Even moar linting

src/services/CommandExecutionService.js

@@ -1,19 +1,22 @@
+/* eslint no-console: 0 */
+
 import StartOfDayIdentifier from './StartOfDayIdentifier';
 import DataAggregator from './DataAggregator';
 import TableCreator from '../services/tables/TableCreator';
 
 export default class CommandExecutionService {
   static executeGamesCommand(dateValue) {
-    return DataAggregator.aggregate(StartOfDayIdentifier.identify(dateValue))
-                         .then((data) => TableCreator.create(data))
-                         .then((tables) => CommandExecutionService.printTables(tables));
+    return DataAggregator
+      .aggregate(StartOfDayIdentifier.identify(dateValue))
+      .then(data => TableCreator.create(data))
+      .then(tables => CommandExecutionService.printTables(tables));
   }
 
   static printTables(tables) {
-    if (tables.started.size > 0) {
-      tables.started.forEach((table) => console.log(table));
-    } else {
+    if (tables.started.empty) {
       console.log('No started games');
+    } else {
+      tables.started.forEach(table => console.log(table));
     }
 
     if (tables.upcoming) {

src/services/PeriodFormatter.js

@@ -1,5 +1,3 @@
-'use es6';
-
 export default class PeriodFormatter {
   static format(period) {
     return period > 4

src/services/tables/PlaysTableCreator.js

@@ -4,20 +4,20 @@ import { PLAY_TIME_EMOJI } from '../../constants/Constants';
 import PeriodFormatter from '../PeriodFormatter';
 
 export default class PlaysTableCreator {
-  static create(data)  {
+  static create(data) {
     const table = new Table({
       head: [
         {
           content: PLAY_TIME_EMOJI,
-          hAlign: 'center'
+          hAlign: 'center',
         },
         {
           content: 'Description',
-          hAlign: 'center'
+          hAlign: 'center',
         },
       ],
     });
-    data.forEach((play) => table.push(PlaysTableCreator.buildRow(play)));
+    data.forEach(play => table.push(PlaysTableCreator.buildRow(play)));
     return table.toString();
   }
 

src/services/tables/StartedGameTableCreator.js

@@ -2,24 +2,17 @@ import colors from 'colors';
 import Table from 'cli-table2';
 
 import Constants from '../../constants/Constants';
-import Score from '../../data/Score';
 
 export default class StartedGameTableCreator {
   static create(data) {
     const table = new Table({ head: StartedGameTableCreator.buildHeaders(data) });
-
-    StartedGameTableCreator.generateRows(data)
-                          .forEach(row => table.push(row));
-
+    StartedGameTableCreator.generateRows(data).forEach(row => table.push(row));
     return table.toString();
   }
 
   static buildHeaders(data) {
-    const periodHeaders = data.scoring.getPeriodValues()
-                                      .map((period) => period.bold.cyan)
-                                      .toJS();
     return ['', data.status.name.bold.magenta]
-      .concat(periodHeaders)
+      .concat(data.scoring.getPeriodValues().map(period => period.bold.cyan).toJS())
       .concat('Total'.bold.underline.cyan);
   }
 
@@ -32,12 +25,18 @@ export default class StartedGameTableCreator {
     const rowNumbers = data.scoring.periods.size + 3;
     const rows = [];
 
-    rows.push(StartedGameTableCreator.generateMetadataRow(Constants.START_TIME_EMOJI,
-                                                          data.getLocalizedStartDateTime(),
-                                                          rowNumbers));
-    rows.push(StartedGameTableCreator.generateMetadataRow(Constants.BROADCASTS_EMOJI,
-                                                          data.getTvBroadcastsString(),
-                                                          rowNumbers));
+    rows.push(StartedGameTableCreator.generateMetadataRow(
+      Constants.START_TIME_EMOJI,
+      data.getLocalizedStartDateTime(),
+      rowNumbers,
+    ));
+
+    rows.push(StartedGameTableCreator.generateMetadataRow(
+      Constants.BROADCASTS_EMOJI,
+      data.getTvBroadcastsString(),
+      rowNumbers,
+    ));
+
     return rows;
   }
 
@@ -61,11 +60,11 @@ export default class StartedGameTableCreator {
     ];
     const visitorRow = [
       Constants.VISITOR_EMOJI,
-      data.matchup.awayTeam.getFormattedTeamAbbreviation()
+      data.matchup.awayTeam.getFormattedTeamAbbreviation(),
     ];
 
-    data.scoring.periods.forEach(periodScore => {
-      let formattedScore = periodScore.score.format();
+    data.scoring.periods.forEach((periodScore) => {
+      const formattedScore = periodScore.score.format();
       homeRow.push(formattedScore.home);
       visitorRow.push(formattedScore.away);
     });

src/services/tables/TableCreator.js

@@ -11,8 +11,8 @@ import UpcomingGamesTableCreator from './UpcomingGamesTableCreator';
 export default class TableCreator {
   static create(data) {
     const upcomingTable = data.upcoming.isEmpty()
-        ? undefined
-        : UpcomingGamesTableCreator.create(data.upcoming)
+      ? undefined
+      : UpcomingGamesTableCreator.create(data.upcoming);
     return new GamesTables({
       started: List(data.started.map(game => TableCreator.createGameTable(game))),
       upcoming: upcomingTable,

src/services/tables/UpcomingGamesTableCreator.js

@@ -5,7 +5,7 @@ import Constants from '../../constants/Constants';
 export default class UpcomingGamesTableCreator {
   static create(data) {
     const table = new Table({ head: UpcomingGamesTableCreator.getHeaders() });
-    data.forEach((metadata) => table.push(UpcomingGamesTableCreator.format(metadata)));
+    data.forEach(metadata => table.push(UpcomingGamesTableCreator.format(metadata)));
     return table.toString();
   }
 
@@ -28,6 +28,6 @@ export default class UpcomingGamesTableCreator {
       Constants.LOCATION_EMOJI,
     ];
 
-    return values.map((value) => ({ content: value, hAlign: 'center' }));
+    return values.map(value => ({ content: value, hAlign: 'center' }));
   }
 }

src/services/translators/BoxScoreDataTranslator.js

@@ -1,6 +1,6 @@
-'use es6';
+/* eslint no-prototype-builtins: 0 */
 
-import {List} from 'immutable';
+import { List } from 'immutable';
 
 import GameBoxScoreLeaders from '../../data/GameBoxScoreLeaders';
 import TeamBoxScoreLeaders from '../../data/TeamBoxScoreLeaders';
@@ -9,58 +9,58 @@ import Player from '../../data/Player';
 
 export default class BoxScoreDataTranslator {
   static translateStatLeaders(data) {
-    let leaders = List(data.leader.map(leader => new Player({
-      firstName: leader.FirstName,
-      lastName: leader.LastName
-    })));
-    return new StatisticalLeaders({ value: parseInt(data.StatValue), leaders: leaders });
+    const leaders = List(data.leader.map(leader =>
+      new Player({
+        firstName: leader.FirstName,
+        lastName: leader.LastName,
+      })));
+
+    return new StatisticalLeaders({ value: parseInt(data.StatValue, 10), leaders });
   }
 
   static translateBoxScoreData(data) {
-    let visitorLeaders = data.sports_content.game.visitor.Leaders;
-    let homeLeaders = data.sports_content.game.home.Leaders;
+    const visitorLeaders = data.sports_content.game.visitor.Leaders;
+    const homeLeaders = data.sports_content.game.home.Leaders;
 
-    let visitorPointsLeaders = new StatisticalLeaders();
-    if (visitorLeaders.hasOwnProperty('Points')) {
-      visitorPointsLeaders = BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Points);
-    }
+    const visitorPointsLeaders = visitorLeaders.hasOwnProperty('Points')
+      ? BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Points)
+      : new StatisticalLeaders();
 
-    let visitorAssistsLeaders = new StatisticalLeaders();
-    if (visitorLeaders.hasOwnProperty('Assists')) {
-      visitorAssistsLeaders = BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Assists);
-    }
+    const visitorAssistsLeaders = visitorLeaders.hasOwnProperty('Assists')
+      ? BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Assists)
+      : new StatisticalLeaders();
 
-    let visitorReboundsLeaders = new StatisticalLeaders();
-    if (visitorLeaders.hasOwnProperty('Rebounds')) {
-      visitorReboundsLeaders = BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Rebounds);
-    }
+    const visitorReboundsLeaders = visitorLeaders.hasOwnProperty('Rebounds')
+      ? BoxScoreDataTranslator.translateStatLeaders(visitorLeaders.Rebounds)
+      : new StatisticalLeaders();
 
-    let homePointsLeaders = new StatisticalLeaders();
-    if (homeLeaders.hasOwnProperty('Points')) {
-      homePointsLeaders = BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Points);
-    }
+    const homePointsLeaders = homeLeaders.hasOwnProperty('Points')
+      ? BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Points)
+      : new StatisticalLeaders();
 
-    let homeAssistsLeaders = new StatisticalLeaders();
-    if (homeLeaders.hasOwnProperty('Assists')) {
-      homeAssistsLeaders = BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Assists);
-    }
+    const homeAssistsLeaders = homeLeaders.hasOwnProperty('Assists')
+      ? BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Assists)
+      : new StatisticalLeaders();
 
-    let homeReboundsLeaders = new StatisticalLeaders();
-    if (homeLeaders.hasOwnProperty('Rebounds')) {
-      homeReboundsLeaders = BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Rebounds);
-    }
+    const homeReboundsLeaders = homeLeaders.hasOwnProperty('Rebounds')
+      ? BoxScoreDataTranslator.translateStatLeaders(homeLeaders.Rebounds)
+      : new StatisticalLeaders();
 
-    let visitorBoxScoreLeaders = new TeamBoxScoreLeaders({
+    const visitorBoxScoreLeaders = new TeamBoxScoreLeaders({
       points: visitorPointsLeaders,
       assists: visitorAssistsLeaders,
       rebounds: visitorReboundsLeaders,
     });
 
-    let homeBoxScoreLeaders = new TeamBoxScoreLeaders({
+    const homeBoxScoreLeaders = new TeamBoxScoreLeaders({
       points: homePointsLeaders,
       assists: homeAssistsLeaders,
       rebounds: homeReboundsLeaders,
     });
-    return new GameBoxScoreLeaders({home: homeBoxScoreLeaders, visitor: visitorBoxScoreLeaders});
+
+    return new GameBoxScoreLeaders({
+      home: homeBoxScoreLeaders,
+      visitor: visitorBoxScoreLeaders,
+    });
   }
 }

src/services/translators/PlaysTranslator.js

@@ -9,7 +9,7 @@ export default class PlaysTranslator {
     return List(recentPlays.map(play => new Play({
       description: play.description,
       clock: play.clock,
-      period: parseInt(play.period),
+      period: parseInt(play.period, 10),
       teamAbbreviation: play.team_abr,
     })));
   }