Merge f8accc2 into caf30ef

src/data/GameScoring.js

@@ -11,6 +11,6 @@ let defaults = {
 
 export default class GameScoring extends Record(defaults) {
   getPeriodValues() {
-    return this.periods.map(periodScore => periodScore.formatPeriod());
+    return List(this.periods.map(periodScore => periodScore.formatPeriod()));
   }
 }

src/data/PeriodScore.js

@@ -1,5 +1,6 @@
 import {Record} from 'immutable';
 import Score from './Score';
+import PeriodFormatter from '../services/PeriodFormatter';
 
 let defaults = {
   period: 1,
@@ -8,6 +9,6 @@ let defaults = {
 
 export default class PeriodScore extends Record(defaults){
   formatPeriod() {
-    return this.period > 4 ? `OT${this.period - 4}` : `Q${this.period}`;
+    return PeriodFormatter.format(this.period);
   }
 };

src/data/Play.js

@@ -2,6 +2,8 @@
 
 import {Record} from 'immutable';
 
+import PeriodFormatter from '../services/PeriodFormatter';
+
 let defaults = {
   description: '',
   clock: '',
@@ -11,11 +13,6 @@ let defaults = {
 
 export default class Play extends Record(defaults) {
   formatPeriod() {
-    let value = this.period - 4;
-    if (value > 0) {
-      return 'OT'.concat(value);
-    }
-
-    return 'Q'.concat(this.period);
+    return PeriodFormatter.format(this.period);
   }
 }

src/services/PeriodFormatter.js

@@ -0,0 +1,9 @@
+'use es6';
+
+export default class PeriodFormatter {
+  static format(period) {
+    return period > 4
+      ? `OT${period - 4}`
+      : `Q${period}`;
+  }
+}

test/GameScoringTest.js

@@ -0,0 +1,31 @@
+'use es6';
+
+import chai from 'chai';
+import chaiImmutable from 'chai-immutable';
+import {List} from 'immutable';
+
+import GameScoring from '../src/data/GameScoring';
+import PeriodScore from '../src/data/PeriodScore';
+import Score from '../src/data/Score';
+
+chai.use(chaiImmutable);
+
+let expect = chai.expect;
+
+describe('Game Scoring Test', function() {
+  let periodScore = new PeriodScore({
+    period: 1,
+    score: new Score({
+      home: 2,
+      away: 3
+    })
+  });
+  let periods = List.of(periodScore, periodScore);
+  let gameScoring = new GameScoring({
+    periods: periods
+  });
+  it('should get period values', function() {
+    let expected = List.of('Q1', 'Q1');
+    expect(gameScoring.getPeriodValues()).to.eql(expected);
+  })
+});

test/PeriodFormatterTest.js

@@ -0,0 +1,12 @@
+'use es6';
+
+import {expect} from 'chai';
+
+import PeriodFormatter from '../src/services/PeriodFormatter';
+
+describe('Test Period Formatter', function() {
+  it('should test period formatting', function() {
+    expect(PeriodFormatter.format(1)).to.equal('Q1');
+    expect(PeriodFormatter.format(5)).to.equal('OT1');
+  });
+});

test/PeriodScoreTest.js

@@ -0,0 +1,19 @@
+'use es6';
+
+import {expect} from 'chai';
+
+import PeriodScore from '../src/data/PeriodScore';
+import Score from '../src/data/Score';
+
+describe('Period Score Test', function() {
+  let overtimePeriod = new PeriodScore({
+    period: 5,
+  });
+  let nonOvertimePeriod = new PeriodScore({
+    period: 2
+  });
+  it('should test period score formatting', function() {
+    expect(overtimePeriod.formatPeriod()).to.equal('OT1');
+    expect(nonOvertimePeriod.formatPeriod()).to.equal('Q2');
+  });
+});

test/Team.js

@@ -30,4 +30,14 @@ describe('Team model', function() {
 
     expect(customTeam.getName()).to.equal('city nickname');
   });
+
+  it('get formatted team abbreviation', function() {
+    let bostonCeltics = new Team({
+      city: 'Boston',
+      nickname: 'Celtics',
+      abbreviation: 'BOS'
+    });
+
+    expect(bostonCeltics.getFormattedTeamAbbreviation()).to.eql('BOS 🍀');
+  });
 });