Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v1 #66

Merged
merged 39 commits into from
Jun 12, 2018
Merged

Upgrade v1 #66

merged 39 commits into from
Jun 12, 2018

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented Jun 12, 2018

Hopefully resolves most of the concerns addressed in #36

* build(babel): update Babel configuration

* build(config): update config files

* style(linting): temporarily turn off linting
* refactor(coordinate): remove Coordinate data class

* refactor(distance): remove Distance class
* refactor(time-estimate): remove TimeEstimate class

* refactor(pickup-time-estimate): remove PickupTimeEstimate class

* refactor(price-estimates): remove PriceEstimates class
* refactor(time-estimates): remove TimeEstimates class

* refactor(price-estimate): remove PriceEstimate class

* refactor(trip-price-estimate): remove TripPriceEsimate class
Renaming services. Converting to functional from class-based.
Remove test directory, update .npmignore, update .eslintignore, update .travis.yml
@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@05b2390). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #66   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      9           
  Lines             ?    100           
  Branches          ?     11           
=======================================
  Hits              ?    100           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/services/symbols.js 100% <100%> (ø)
src/services/converters.js 100% <100%> (ø)
src/data/DistanceUnit.js 100% <100%> (ø)
src/services/AddressLocator.js 100% <100%> (ø)
src/services/formatters.js 100% <100%> (ø)
src/data/TimeUnit.js 100% <100%> (ø)
src/services/tables/time/build.js 100% <100%> (ø)
src/services/tables/price/build.js 100% <100%> (ø)
src/services/UberService.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b2390...22f4f41. Read the comment docs.

@jaebradley jaebradley merged commit d415987 into master Jun 12, 2018
@jaebradley jaebradley deleted the upgrade-v1 branch June 12, 2018 19:04
@jaebradley jaebradley mentioned this pull request Jun 12, 2018
3 tasks
@jaebradley
Copy link
Owner Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant