Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warns if the user fires in unknown commands #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

open-source-explorer
Copy link

@open-source-explorer open-source-explorer commented Jan 18, 2019

Closes #80

Currently, uber <random-command> works seamlessly without any sort of warnings which shouldn't be the case.

Copy link
Owner

@jaebradley jaebradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-source-explorer thanks for your contribution (and apologies for the tardiness of my review)!

This looks like a nice win that will help user experience.

Just a couple follow-up items!

src/executables/uber.js Outdated Show resolved Hide resolved
src/executables/uber.js Outdated Show resolved Hide resolved
src/executables/uber.js Outdated Show resolved Hide resolved
src/executables/uber.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants