Add request^2.79.0 to dependencies #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2017 07:29
This makes "npm i --save library" work better
Fixes error: 'The "request" library is not installed automatically anymore.'
|
@paulkernfeld great catch! There's an issue with the Travis build right now - here's the error description: I think it's related to how the test environment variables (I'm using dotenv) are being defined especially with respect to Travis (I have test application credentials so that I can run integration tests as part of the build process). I'm going to investigate this and get to the bottom of the issue. Goal is to have this PR merged by EOW. Thanks again! |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jae,
This is a great library!
This PR should fix an error that I ran into while i was installing
uber-cli.