Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-sudo for UI actions when in container #903

Open
10 tasks done
daredoes opened this issue May 16, 2023 · 2 comments · Fixed by #907
Open
10 tasks done

Allow non-sudo for UI actions when in container #903

daredoes opened this issue May 16, 2023 · 2 comments · Fixed by #907

Comments

@daredoes
Copy link
Contributor

Iris version

3.66.1

Operating system(s) affected

  • Windows
  • MacOS
  • iOS
  • Android
  • Linux
  • Other

Browser(s) affected

  • Firefox
  • Chrome
  • Edge
  • Other

What happened?

When any button in the UI is pressed to trigger actions in system.sh, the call fails when sudo is not available due to line 28 in system.py.

It should be something like this

    _USE_SUDO = not os.path.exists('/IS_CONTAINER')

Logs

No response

@daredoes daredoes added the bug label May 16, 2023
@daredoes
Copy link
Contributor Author

Love the library. Happy to help with other features/issues if there are specific desires/requests. My time, like all of ours, is limited. Iris has given to me, and I like to give back though.

@guikubivan
Copy link

This is awesome, been banging my head on why the button in the UI doesn't work. Will patch my Dockerfile for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants