3.66 #879
Merged
3.66 #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jaedb
commented
Jan 14, 2023
jaedb
commented
- GitHub actions hooks and release auto-tagging (release = build + release, push = build)
- Dockerfile upgrade (Spotify support, WIP)
- Multi-stage Docker build for reduced filesize and build time
- Minor bugfixes
- Can create and edit playlists - Can now load playlists natively
- Needs monitoring on heavier backends (YTMusic, Tidal, etc) - Doesn't conflict with PlaylistGroups
Do not show discovery menu when spotify is not used
- Matches Spotify artwork, which we hide when it is burned-in on the image - Consistent across all providers now
- Cannot safely (and consistently) overwrite PIP-installed package with host volume binding, so is easier to build within Docker - Add `.nvmrc` for consistent buildout
- Need to experiment with file size reduction
Moved the build process of the GStreamer plugins to a separate stage. Restructured the file a bit and cleaned up some unused dependencies.
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
==========================================
+ Coverage 10.57% 11.84% +1.27%
==========================================
Files 169 169
Lines 9722 9709 -13
Branches 73 73
==========================================
+ Hits 1028 1150 +122
+ Misses 8694 8559 -135
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- Enabled basic version via GitHub directly
- Escape to a space; may need expanding on if more characters start appearing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -122,7 +122,7 @@ | |||
| to = `/${item.type}/${encodeUri(item.uri)}`; | |||
| if (item.name && item.type !== 'artist') { | |||
| // Strip out "%"; this causes conflicts with our uri decoder | |||
| to += `/${encodeURIComponent(item.name.replace('%', ''))}`; | |||
| to += `/${encodeURIComponent(item.name.replace('%', '').replace('/', ''))}`; | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| @@ -140,7 +140,7 @@ | |||
| items={moods} | |||
| details={['playlists']} | |||
| right_column={['source']} | |||
| getLink={(item) => `/discover/moods/${encodeUri(item.uri)}/${item.name}`} | |||
| getLink={(item) => `/discover/moods/${encodeUri(item.uri)}/${encodeURIComponent(item.name.replace('%', '').replace('/', ''))}`} | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| @@ -150,7 +150,7 @@ | |||
| <section className="content-wrapper"> | |||
| <Grid | |||
| items={moods} | |||
| getLink={(item) => `/discover/moods/${encodeUri(item.uri)}/${item.name}`} | |||
| getLink={(item) => `/discover/moods/${encodeUri(item.uri)}/${encodeURIComponent(item.name.replace('%', '').replace('/', ''))}`} | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.