Search refactor #892
Search refactor #892
Conversation
jaedb
commented
Apr 1, 2023
jaedb
commented
- Remove filtering of sources
- Migrate search to functional component(s)
- By using route, it makes it more readily available for the varying component structure - I believe I handn't done this earlier to avoid refactoring, but it wasn't a complex task - Removing link borders, the browser-provided standard underline hover is now much more astheticly pleasing
|
Hello @jaedb - May I know why filtering by sources was removed? It was highly useful in restricting my searches between local and YouTube. Since the removal, I see too many results and am unable to find which is from what. I may have missed any announcement that may have triggered this change. If you can point me to that happy to read and understand. Thank you. |
|
I also have to agree with jalabulajunx, filtering by source was very useful to me too. In my case it's the mix between youtube and spotify that is problematic. Most of the time I'm looking for a spotify song, but no wthe search results are polluted with mostly youtube results. I'd be happy to contribute a PR that brings source filtering back using hooks. Would you merge that @jaedb? |
|
Please see #906 |
