Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow to validate generated Docker image #33

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add CI workflow to validate generated Docker image #33

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0876a97
add workflow to validate docker image
akagami-harsh Nov 11, 2023
a76a961
fix typo
akagami-harsh Nov 11, 2023
6f8f6ff
fix
akagami-harsh Nov 11, 2023
dea4642
add build step for jaeger-idl
akagami-harsh Nov 12, 2023
937963f
fix
akagami-harsh Nov 12, 2023
79fba72
fix
akagami-harsh Nov 12, 2023
c7117ca
fix
akagami-harsh Nov 12, 2023
f5f89e8
Update ci-docker-image-validation.yml
akagami-harsh Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/ci-docker-image-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Docker Image Validation
on:
push:
branches:
- master
pull_request:
branches:
- master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the trigger conditions be consistent with existing build tasks?

https://github.com/jaegertracing/docker-protobuf/blob/master/.github/workflows/jaeger-dockerimage.yml

on: 
  push:
    tags:
      - '**'
    branches:
      - master
  pull_request:
    paths: 
      - .github/workflows/jaeger-dockerimage.yml
      - Dockerfile
      - protoc-wrapper

Alternatively, checkout and build proto can be integrated directly into the original CI so that we can directly confirm a successful build before the image is released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added triggers same as the jaeger-dockerimage.yml in this workflow


jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Build the Docker image
run: docker buildx build -t protobuf .

- name: Checkout jaeger
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger
path: jaeger

- name: Checkout jaeger-idl
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger-idl
path: jaeger-idl

- name: Build Proto in Jaeger
working-directory: jaeger
run: |
make init-submodules
make proto JAEGER_DOCKER_PROTOBUF=protobuf

- name: Build Proto in Jaeger-idl
working-directory: jaeger-idl
run: |
make init-submodule
make proto PROTOC_IMAGE=protobuf