Adding some additional clarification for mentees. #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yurishkuro
reviewed
Feb 6, 2024
content/mentorship-for-mentees.md
Outdated
| @@ -29,7 +29,12 @@ It does not mean that the longer the proposal the better. It's about the quality | |||
| In order to understand the project better and come up with reasonable solutions, it's always helpful to become familiar with Jaeger and its code base. We strongly recommend: | |||
|
|
|||
| * Going through some Jaeger tutorials, such as [this one][hotrod]. | |||
| * Trying to solve some of the [simple open issues](../get-involved/) that you can find across Jaeger repositories. | |||
| * Review the hotrod video demo and tutorial such as [this video on youtube][hotrod_video]. | |||
There was a problem hiding this comment.
Suggested change
| * Review the hotrod video demo and tutorial such as [this video on youtube][hotrod_video]. |
yurishkuro
reviewed
Feb 6, 2024
content/mentorship-for-mentees.md
Outdated
| @@ -29,7 +29,12 @@ It does not mean that the longer the proposal the better. It's about the quality | |||
| In order to understand the project better and come up with reasonable solutions, it's always helpful to become familiar with Jaeger and its code base. We strongly recommend: | |||
|
|
|||
| * Going through some Jaeger tutorials, such as [this one][hotrod]. | |||
There was a problem hiding this comment.
Suggested change
| * Going through some Jaeger tutorials, such as [this one][hotrod]. | |
| * Going through some Jaeger tutorials, such as [HotROD blog post][hotrod] or [YouTube video][hotrod_video] |
yurishkuro
reviewed
Feb 6, 2024
content/mentorship-for-mentees.md
Outdated
| @@ -29,7 +29,12 @@ It does not mean that the longer the proposal the better. It's about the quality | |||
| In order to understand the project better and come up with reasonable solutions, it's always helpful to become familiar with Jaeger and its code base. We strongly recommend: | |||
|
|
|||
| * Going through some Jaeger tutorials, such as [this one][hotrod]. | |||
| * Trying to solve some of the [simple open issues](../get-involved/) that you can find across Jaeger repositories. | |||
| * Review the hotrod video demo and tutorial such as [this video on youtube][hotrod_video]. | |||
| * Run the [hotrod demo yourself][hotrod_repo] as the blogs and video is outdated, it's good to get hands on. | |||
There was a problem hiding this comment.
Suggested change
| * Run the [hotrod demo yourself][hotrod_repo] as the blogs and video is outdated, it's good to get hands on. | |
| * Run the [HotROD demo yourself][hotrod_repo] as the blogs and video is outdated, it's good to get hands on. |
HotROD ™️
yurishkuro
reviewed
Feb 6, 2024
content/mentorship-for-mentees.md
Outdated
| * Trying to solve some of the [simple open issues](../get-involved/) that you can find across Jaeger repositories. | ||
| * Review the hotrod video demo and tutorial such as [this video on youtube][hotrod_video]. | ||
| * Run the [hotrod demo yourself][hotrod_repo] as the blogs and video is outdated, it's good to get hands on. | ||
| * Review the Jaeger architecture from the [documentation](https://www.jaegertracing.io/docs/architecture/) and understand the microservices architecture. |
There was a problem hiding this comment.
Suggested change
| * Review the Jaeger architecture from the [documentation](https://www.jaegertracing.io/docs/architecture/) and understand the microservices architecture. | |
| * Review the [Jaeger architecture documentation](https://www.jaegertracing.io/docs/architecture/) and understand the microservices architecture. |
understand the microservices architecture.
what do you mean by that?
There was a problem hiding this comment.
better to use relative path
There was a problem hiding this comment.
Understanding of the components in the architecture is another way to phrase it, if you prefer.
I will edit to use relative on the push.
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some of the questions we are getting from our new Mentees we wanted to add some additional pointers and clarification ot make it easier for them to get started.
Added link for the current ongoing LFX mentorship.
Checklist
Tested new page locally.