-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Navbar hover background color much darker #690
Conversation
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
d267d7f
to
5ce8396
Compare
Do you mean like this? (only left and right sidebar, not included content) 2024-04-04.1.10.53.mov |
Not quite - this changes all links, I was only thinking of the menus and the highlights would be row level, not text-only, similar to how it's in the top nav bar |
Disclaimer: I'm not a UI/UX designer; I'm just examining it from my own aesthetic point of view. The right-side menu is OK. 2024-04-05.2.08.25.movBut we can open a new issue to discuss this. |
you're right, the right side menu is already using row highlighting, only the left one doesn't. The 2nd video looks great as an example (it even does indentation of the highlight on children menu items) |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test