Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Navbar hover background color much darker #690

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

tico88612
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Navbar hover background color much darker

How was this change tested?

  • manual test

Checklist

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 5ce8396
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/660e14147a890800081e2821
😎 Deploy Preview https://deploy-preview-690--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@yurishkuro
Copy link
Member

Do you think we can also add this highlighting to the left and right sidebar menus?

image

@tico88612
Copy link
Contributor Author

tico88612 commented Apr 4, 2024

Do you mean like this? (only left and right sidebar, not included content)

2024-04-04.1.10.53.mov

@yurishkuro
Copy link
Member

Not quite - this changes all links, I was only thinking of the menus and the highlights would be row level, not text-only, similar to how it's in the top nav bar

@tico88612
Copy link
Contributor Author

tico88612 commented Apr 4, 2024

Disclaimer: I'm not a UI/UX designer; I'm just examining it from my own aesthetic point of view.


The right-side menu is OK.
Does the left menu look like this movie if it is changed to look like the navigation bar above? (from bulma.io)

2024-04-05.2.08.25.mov

But we can open a new issue to discuss this.

@yurishkuro
Copy link
Member

you're right, the right side menu is already using row highlighting, only the left one doesn't. The 2nd video looks great as an example (it even does indentation of the highlight on children menu items)

@yurishkuro yurishkuro merged commit 89637b6 into jaegertracing:main Apr 5, 2024
10 checks passed
@tico88612 tico88612 deleted the fix/navbar-bgc-hover branch April 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Use darker background for topnav menu mouseover
2 participants