Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set sidecar.istio.io Pod annotations in jaeger pod #355

Closed
cnvergence opened this issue Apr 15, 2022 · 3 comments
Closed

Unable to set sidecar.istio.io Pod annotations in jaeger pod #355

cnvergence opened this issue Apr 15, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@cnvergence
Copy link
Contributor

Describe the bug
Currently, we are unable to add annotations properly to a Jaeger pod using Jaeger-operator.

To Reproduce
Applying those annotations in the values of Jaeger-operator helm chart.

jaeger:
  spec:
    annotations:
      sidecar.istio.io/inject: "true"
      sidecar.istio.io/rewriteAppHTTPProbers: "true"

This will result in the following istioctl analyze warnings:

Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/inject can only be applied to Pod
Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/rewriteAppHTTPProbers can only be applied to Pod

I tried then to apply them to the Pods, with those values:

jaeger:
  spec:
    template:
      metadata:
        annotations:
          sidecar.istio.io/inject: "true"
          sidecar.istio.io/rewriteAppHTTPProbers: "true"

The result was, that it did not update those annotations in the pods, instead, it got overwritten with
sidecar.istio.io/inject: "false" annotation

Expected behaviour
It should be possible to control Pod annotations on Jaeger pods controlled by Jaeger-operator.

Version (please complete the following information):

  • OS: [e.g. Linux]
  • Jaeger version: 1.30.0
  • Deployment: Kubernetes with Jaeger Operator
@cnvergence
Copy link
Contributor Author

cnvergence commented Apr 15, 2022

The place of an overwrite sidecar.istio.io/inject: "false" should be fixed with this PR

@dimitarshenkov
Copy link

dimitarshenkov commented May 25, 2022

jaeger:
  spec:
    template:
      metadata:
        annotations:
          sidecar.istio.io/inject: "true"
          sidecar.istio.io/rewriteAppHTTPProbers: "true"

this Operator values Did not add the sidecar.istio.io/inject: "true"` to the pod

@cnvergence
Copy link
Contributor Author

cnvergence commented Sep 23, 2022

Adding those values will set annotations properly

jaeger:
  spec:
    allInOne:
      annotations:
        sidecar.istio.io/inject: "true"
        sidecar.istio.io/rewriteAppHTTPProbers: "true"        

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants