Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: setting default Istio annotation in Pod instead of Deployment #1860

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Apr 15, 2022

Properly add istio annotation to Pod instead of Deployment.
Fixes istioctl analyze warning

Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/inject can only be applied to Pod

Which problem is this PR solving?

Resolves:

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
frzifus
frzifus previously approved these changes Apr 18, 2022
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. What do you think @rubenvp8510 ?

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
Copy link
Contributor Author

hey @frzifus, could you take a look again, please?
I have updated this PR, so I think it can solve the problem with sidecar.istio.io annotations

frzifus
frzifus previously approved these changes Apr 19, 2022
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@rubenvp8510
Copy link
Collaborator

makes sense to me. What do you think @rubenvp8510 ?

Yep, it makes sense to me.

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1860 (7166d96) into main (7eaf8c3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
+ Coverage   89.42%   89.44%   +0.01%     
==========================================
  Files         100      100              
  Lines        6118     6128      +10     
==========================================
+ Hits         5471     5481      +10     
  Misses        471      471              
  Partials      176      176              
Impacted Files Coverage Δ
pkg/deployment/agent.go 100.00% <100.00%> (ø)
pkg/deployment/all_in_one.go 100.00% <100.00%> (ø)
pkg/deployment/collector.go 100.00% <100.00%> (ø)
pkg/deployment/ingester.go 100.00% <100.00%> (ø)
pkg/deployment/query.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523f7cf...7166d96. Read the comment docs.

@cnvergence
Copy link
Contributor Author

@rubenvp8510 @frzifus I needed to update this branch, ptal
Thanks!

@frzifus
Copy link
Member

frzifus commented Apr 21, 2022

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants