Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support InitContainer in collector #452

Closed
pie-r opened this issue Mar 6, 2023 · 0 comments · Fixed by #453
Closed

[Feature]: Support InitContainer in collector #452

pie-r opened this issue Mar 6, 2023 · 0 comments · Fixed by #453
Labels
enhancement New feature or request

Comments

@pie-r
Copy link
Contributor

pie-r commented Mar 6, 2023

Requirement

Jaeger Operator doesn't support yet Elasticsearch 8, for this reason users have to

   storage:
      type: elasticsearch
      secretName: ${elasticsearch_credentials_secret}
      options:
        es:
          server-urls: http://${elasticsearch_url}
          max-span-age: ${elasticsearch_retention * 24}h
          version: 7                                                 # Necessary as it doesn't work with 8 yet
          create-index-templates: false               # Necessary as it doesn't work with 8 yet

The index-tempalte could be added as initContainer to the collector manifest.

Reference: jaegertracing/jaeger#3571

Problem

Jaeger doesn't support yet Elasticsearch 8.x

Proposal

Add an InitContainter section in the elasticsearch collector manifest

Open questions

No response

@pie-r pie-r added the enhancement New feature or request label Mar 6, 2023
pie-r added a commit to pie-r/helm-charts-jaeger that referenced this issue Mar 6, 2023
Signed-off-by: Pier <53210578+pie-r@users.noreply.github.com>
pavelnikolov pushed a commit that referenced this issue Mar 7, 2023
* feat: #452 support initContainers

Signed-off-by: Pier <53210578+pie-r@users.noreply.github.com>

* missing if

Signed-off-by: Pier <53210578+pie-r@users.noreply.github.com>

---------

Signed-off-by: Pier <53210578+pie-r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant